From nobody Mon Feb 9 11:38:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573571437; cv=none; d=zoho.com; s=zohoarc; b=aKm1hmHnPoD+cz+wNYDKlt+Yd9iL+0ESDPbcHTwUgWPHnytrEEKok+DXRPfq0298RCuzvaqvStBixPIM4SoACOXKhgNOqdN2xw93apZKrjRmjvZ9DhLG1b+5FtcQtQZXfzAmNGoJHvtlFBv3mek9sbUgHtRQksDDO2jyigh1Wz4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573571437; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+3ZcmdrsXORaEcOw/qL8KFh9Zkq4FhziELzAcdBKbmk=; b=iXtinvLX5XKw60lG9FPIpWyMLKYTNp43aDnkXqTzPnrLJ0hexnGQdacvA3SC+Dt9yrBSMEb6dOVbQs4TJr9lxhik9FhZ+qGNmId+lt6lURhPYTNTPbgEt95cHgXd79wRjjjuRAYj/wLxqcb4eUu3a5lmxZSMhO7eiSd4SITAEaI= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 157357143778287.59133822283229; Tue, 12 Nov 2019 07:10:37 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-62-UBRMEeMaPbulCo5uZbCGTQ-1; Tue, 12 Nov 2019 10:10:35 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5D5DB477; Tue, 12 Nov 2019 15:10:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3659D101E814; Tue, 12 Nov 2019 15:10:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E7C994E566; Tue, 12 Nov 2019 15:10:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xACFARiE005271 for ; Tue, 12 Nov 2019 10:10:27 -0500 Received: by smtp.corp.redhat.com (Postfix) id BC5A08185; Tue, 12 Nov 2019 15:10:27 +0000 (UTC) Received: from ridgehead.redhat.com (unknown [10.43.2.116]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2064828D2A; Tue, 12 Nov 2019 15:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573571436; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=+3ZcmdrsXORaEcOw/qL8KFh9Zkq4FhziELzAcdBKbmk=; b=MoTtP6RvHAdtUmlxFtAFIC7H2wFNeeyi+DdMUksafCjJ0UR44lOL4+KVLR/9OKVs9LX+rm KnuDXrc+HsSx9D9aVsro2fDNf4zjO5VWDi7XTjxHt8gnOhPGV9gArTotAwyTAnEyhIw1my LIDIQJeFEr6gMbyyjfkNXIJK6YT0Y7k= From: Erik Skultety To: libvir-list@redhat.com Date: Tue, 12 Nov 2019 16:10:19 +0100 Message-Id: <494b3584ac29738809d511075e1737481b3c556c.1573571378.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Erik Skultety Subject: [libvirt] [tck PATCH 2/3] hooks: Refresh the service status after performing an action X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: UBRMEeMaPbulCo5uZbCGTQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Presumably, the original intent of the code was to query the status of the service to refresh the internal state variable, but the intended method was never called because of a typo. --- lib/Sys/Virt/TCK/Hooks.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Sys/Virt/TCK/Hooks.pm b/lib/Sys/Virt/TCK/Hooks.pm index ef3403d..a3615e4 100644 --- a/lib/Sys/Virt/TCK/Hooks.pm +++ b/lib/Sys/Virt/TCK/Hooks.pm @@ -263,7 +263,7 @@ sub service_libvirtd { =20 die "failed on $action daemon" if system $cmd; =20 - $self->libvirtd_status; + $self->libvirtd_status(); } =20 sub compare_log { --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list