From nobody Fri Jul 26 23:44:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1684154073; cv=none; d=zohomail.com; s=zohoarc; b=bJKtj0IfNL8r64ejy1eV69VzImrcWGTJ/q3KmKTXifPuuN5lfFHN/nksOxMdRL+OpeuhlrikXM8wpxOHdaRJu2Tlg+928StAR4lQIRISkmMpf4BSIPQFhhgT9aRyJHXb2vipJwIGTTl4Nz44Oquyud6pdcyW6Uim1p90GoUdGF8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1684154073; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=u9Y2mRToPOR29oi4gDx+vPNZDWsQfSb+FGztgD84/pI=; b=StYOd47HpL5TUzh3nJxtcpoj3sHr6toKDdRUhIXYhxJ4WMY1hXyIQEhP2E2GHiUFFf/+KX9Kj2ItpUxBprj9QWhIrtB7daGygrUmMGXQCqGK0Y+41JkYmhr1nGUnCMAIWyEEXeKlERERzVmABUIkVfhktI6nzFpPzsDOmGzQsGQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1684154073048996.390538681682; Mon, 15 May 2023 05:34:33 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-629-bc2lyxCSPFuiZ3Is-WslpQ-1; Mon, 15 May 2023 08:34:30 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2B3581818CFC; Mon, 15 May 2023 12:34:18 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id EFBAF40C2079; Mon, 15 May 2023 12:34:17 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id AFEBF1946A42; Mon, 15 May 2023 12:34:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BD3CC194658C for ; Mon, 15 May 2023 12:34:16 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id A233814171B6; Mon, 15 May 2023 12:34:16 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 02CAE1410DD5 for ; Mon, 15 May 2023 12:34:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684154072; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=u9Y2mRToPOR29oi4gDx+vPNZDWsQfSb+FGztgD84/pI=; b=EAzUuinYhVpYXowqzl0ftLXdgghhxvooqUnT3fyYnBF76h26bFjZSE3KaeVYVsvcA+Vm1P 5rCtSToXjdISoq9H673mQQC8R+J+0s2LspYTqyzN3pcKn4GXKFcW7eP/N8YKlXKcdhx8ol /4VAqR2oVTuGBQTDAtckXIT9kffMLmM= X-MC-Unique: bc2lyxCSPFuiZ3Is-WslpQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 3/3] schemas: backup: Allow missing 'type' attribute for backup disk Date: Mon, 15 May 2023 14:34:12 +0200 Message-Id: <49235f91acfa706a40531fba85a261c36f64fa88.1684153999.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1684154074555100001 Content-Type: text/plain; charset="utf-8" One of our examples in the 'formatbackup.rst' page shows following config: The schema didn't allow it though. Fix the schema as the internals were supposed to support it (except for the bug fixed in previous patches). Signed-off-by: Peter Krempa --- src/conf/schemas/domainbackup.rng | 4 ++++ tests/domainbackupxml2xmlin/backup-push.xml | 2 ++ tests/domainbackupxml2xmlout/backup-push.xml | 6 ++++++ 3 files changed, 12 insertions(+) diff --git a/src/conf/schemas/domainbackup.rng b/src/conf/schemas/domainbac= kup.rng index bfc29a6c06..80ba155aad 100644 --- a/src/conf/schemas/domainbackup.rng +++ b/src/conf/schemas/domainbackup.rng @@ -166,6 +166,10 @@ no + + + + diff --git a/tests/domainbackupxml2xmlin/backup-push.xml b/tests/domainback= upxml2xmlin/backup-push.xml index a95833d407..f1cb38fa82 100644 --- a/tests/domainbackupxml2xmlin/backup-push.xml +++ b/tests/domainbackupxml2xmlin/backup-push.xml @@ -6,6 +6,8 @@ + + diff --git a/tests/domainbackupxml2xmlout/backup-push.xml b/tests/domainbac= kupxml2xmlout/backup-push.xml index fff7db716b..0c6fa6d4ee 100644 --- a/tests/domainbackupxml2xmlout/backup-push.xml +++ b/tests/domainbackupxml2xmlout/backup-push.xml @@ -8,6 +8,12 @@ + + + + + + --=20 2.40.1