From nobody Mon Feb 9 00:07:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1638282758; cv=none; d=zohomail.com; s=zohoarc; b=ZOKk6zVolyWWZtU5w7TcbjraYku7Tg+Sb61tboexyl6eJKgrp9Ldx/gcsOnKZW4gvxI/Izn9BH6RqFZXu4EqmyXZQmDCY85DWuvx/yisEqGaupM2LNa3xDRITF8zi0CYQEYCxYDJx99v1rpU/Egjrh+/4oET4Dixx8A6k9+o8q0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1638282758; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gYx2rMIhMi8XR+ATsp6v1uHRT2sW9OqJNpr6+PakXfk=; b=hBCy/Fno7Weq1q34/5kJJ3Hjsl6j1hrwDRV3p8FjLh4EB0v01L7YUmt2h51no6ixCfLfPtj6un1XxE4yYQzp10mKLN5CgwbYWujSlXMG54stN9cUzFJtZCxVls6FEsQLIHVcOa7Bp7dRKV6ZP33eGweliXYSB7UYntoMCjPkvj0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1638282758717309.5078525352841; Tue, 30 Nov 2021 06:32:38 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-51-cHLi9suSP9q_Xd0m8VMcIQ-1; Tue, 30 Nov 2021 09:32:36 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B1F210B7440; Tue, 30 Nov 2021 14:32:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B8BF176608; Tue, 30 Nov 2021 14:32:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AB2281809C89; Tue, 30 Nov 2021 14:32:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AUEWOkp022134 for ; Tue, 30 Nov 2021 09:32:24 -0500 Received: by smtp.corp.redhat.com (Postfix) id 2639360C0F; Tue, 30 Nov 2021 14:32:24 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8879E60C4A for ; Tue, 30 Nov 2021 14:32:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638282757; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=gYx2rMIhMi8XR+ATsp6v1uHRT2sW9OqJNpr6+PakXfk=; b=gGz3DeacGxxuxmbEDuIzCmM/2JuI+1LL98B8wIXaHseVNpFGVKa9+2K/0OeVCLbos55LSS f9K6oE8daMlOP8WFWRrFYb74w8N0lnVPD1fHv04wokiL9brYIZ2YO8jcm0QifO9nwj26PR okxjXWd40u3wRRCEWmEU7URFpVLf87k= X-MC-Unique: cHLi9suSP9q_Xd0m8VMcIQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 01/23] virDomainNetDefParseXML: Automatically free GHashTable Date: Tue, 30 Nov 2021 15:31:45 +0100 Message-Id: <48ae681fc70f67c4f9f8ad7effaf1ed5e7adbd9e.1638282671.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1638282760095100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/conf/domain_conf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f88405ab02..25e504a99a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10244,7 +10244,7 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt, xmlNodePtr vlan_node =3D NULL; xmlNodePtr bandwidth_node =3D NULL; xmlNodePtr tmpNode; - GHashTable *filterparams =3D NULL; + g_autoptr(GHashTable) filterparams =3D NULL; virDomainActualNetDef *actual =3D NULL; VIR_XPATH_NODE_AUTORESTORE(ctxt) virDomainChrSourceReconnectDef reconnect =3D {0}; @@ -10431,7 +10431,6 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt, if ((filterref_node =3D virXPathNode("./filterref", ctxt))) { filter =3D virXMLPropString(filterref_node, "filter"); - virHashFree(filterparams); filterparams =3D virNWFilterParseParamAttributes(filterref_node); } @@ -10960,7 +10959,6 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt, cleanup: virDomainActualNetDefFree(actual); - virHashFree(filterparams); return def; error: --=20 2.31.1