From nobody Sun Feb 8 11:40:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604407437; cv=none; d=zohomail.com; s=zohoarc; b=nsd2BC1duNZF6Z1hn+jadFJQQW672dtw81kB7F0GY9+6P4O7OfIY/1968WvEgTgmGadZveNvKthN675fLjsCcV53W7lOlx4vIV0HBu5jZXWoXay10glK2W72jcOTX/hBy9yQf9lPes4c8lsy/LlipnoR5EdUsQS9Rxa0alPgLuQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604407437; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Sf7MSNsiJm375gYXW8rKjIxTt2YnxysTFt0HN5xmLnw=; b=hp1Wev5C7hR1ZwUne4Bf9NJRodeMMqgcy7Nwcbp6Dmvn/223GtTeOILd7HpEduZyvYByNo0yKHS8v1rDkb9BrBeO9BA47JF4JuVkA+r+xcetxFoajz2X5CSflBFjLhAIt8HpXzHdIpudW35bPmn1VMZ8Uh15rqeoPsfGVx/f4k8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1604407437256910.8373531384135; Tue, 3 Nov 2020 04:43:57 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-137-3SIyLM5YMyGGK_m3f1qwhA-1; Tue, 03 Nov 2020 07:42:18 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C32B31007468; Tue, 3 Nov 2020 12:42:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9BD3E1002D4A; Tue, 3 Nov 2020 12:42:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 651F0181A270; Tue, 3 Nov 2020 12:42:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0A3CfrcZ015949 for ; Tue, 3 Nov 2020 07:41:53 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1A38473661; Tue, 3 Nov 2020 12:41:53 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.192.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id 88E4D73667 for ; Tue, 3 Nov 2020 12:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604407436; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Sf7MSNsiJm375gYXW8rKjIxTt2YnxysTFt0HN5xmLnw=; b=KSCwzCzVvFILgBw7HNIoj7DX3k3wGSheAx6Kw+pNVDcK/IFA/Vtoge6q0ImW6bgEuP8QlZ 6xEXzckmjuWiowgNuIwnf3jQ0CZ661WlR3tc8kHxI2y2+qVZEhRWQM7aePLBDyPVuikhNg o+m1JRcho5qlzMSFl+7DBCUtXxEUvk8= X-MC-Unique: 3SIyLM5YMyGGK_m3f1qwhA-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 12/25] vircgroup: introduce virCgroupDetectControllers helper Date: Tue, 3 Nov 2020 13:41:24 +0100 Message-Id: <4890b04ecd6d63dbfbf093970cb66ae776728761.1604407065.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 51 ++++++++++++++++++++++++++++---------------- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 55fa49a398..f21a581946 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -410,6 +410,38 @@ virCgroupValidatePlacement(virCgroupPtr group, } =20 =20 +static int +virCgroupDetectControllers(virCgroupPtr group, + int controllers, + virCgroupPtr parent) +{ + size_t i; + int controllersAvailable =3D 0; + + for (i =3D 0; i < VIR_CGROUP_BACKEND_TYPE_LAST; i++) { + int rc; + + if (!group->backends[i]) + continue; + + rc =3D group->backends[i]->detectControllers(group, controllers, p= arent, + controllersAvailable); + if (rc < 0) + return -1; + controllersAvailable |=3D rc; + } + + /* Check that at least 1 controller is available */ + if (controllersAvailable =3D=3D 0) { + virReportSystemError(ENXIO, "%s", + _("At least one cgroup controller is required= ")); + return -1; + } + + return 0; +} + + static int virCgroupDetect(virCgroupPtr group, pid_t pid, @@ -417,9 +449,6 @@ virCgroupDetect(virCgroupPtr group, const char *path, virCgroupPtr parent) { - size_t i; - int controllersAvailable =3D 0; - VIR_DEBUG("group=3D%p controllers=3D%d path=3D%s parent=3D%p", group, controllers, path, parent); =20 @@ -450,22 +479,8 @@ virCgroupDetect(virCgroupPtr group, if (virCgroupValidatePlacement(group, pid) < 0) return -1; =20 - for (i =3D 0; i < VIR_CGROUP_BACKEND_TYPE_LAST; i++) { - if (group->backends[i]) { - int rc =3D group->backends[i]->detectControllers(group, contro= llers, parent, - controllersAvai= lable); - if (rc < 0) - return -1; - controllersAvailable |=3D rc; - } - } - - /* Check that at least 1 controller is available */ - if (controllersAvailable =3D=3D 0) { - virReportSystemError(ENXIO, "%s", - _("At least one cgroup controller is required= ")); + if (virCgroupDetectControllers(group, controllers, parent) < 0) return -1; - } =20 return 0; } --=20 2.26.2