From nobody Wed Dec 17 08:55:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1744114188; cv=none; d=zohomail.com; s=zohoarc; b=RdDsrF3UexkG1NZR3ue82M5nFSqFwHN56+IhqKe2ZXZmbo3n1xgQkTolyFeHKirL/xGgWr0lfpeKIojs64G4TFpObcldm3zKJ4Yy/Ku6z8sAKTZazUu1I5excWub7oGd553b1xRE19cpCrHD821Iy/ykPIqsNscsjA3YdFlG5nI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744114188; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=ICXb3A1Vsd8DmyhPR6fnilmp/hNUU4O7wB76EMuWJY4=; b=HLbFYvQowdIIENadRJBFErZ3vqPbbEMuJkzr7gmkFWKdxIMFMjctPswwZZ+dWteoLNkxLD2Enh/mHa1xEFuLFWETsma4uSVcZ7Pi+Ihr6OuSkyH2ZzOAjMTx8APdVJdXf68QBCnQWHyfuAWguajLXOguWeVIuJ2AXgqmpawGaZg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1744114188223809.6684474364534; Tue, 8 Apr 2025 05:09:48 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 2790B167C; Tue, 8 Apr 2025 08:09:47 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 6618F157C; Tue, 8 Apr 2025 08:09:25 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 25E681562; Tue, 8 Apr 2025 08:09:22 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 84BC3155E for ; Tue, 8 Apr 2025 08:09:21 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-503-lKvKZMCoM4ySp-2AaNFlBg-1; Tue, 08 Apr 2025 08:09:19 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2A0B91800263 for ; Tue, 8 Apr 2025 12:09:19 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.8]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7171C18009BC for ; Tue, 8 Apr 2025 12:09:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744114161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hyWqdmyXEmas1yhStQB9zYCN+SOYdqacDKlI1hbOEpE=; b=RZxL8YGK/+bsJ6t+aHllHXmu1SHdgIXj4sdMf7LeCOAuvP+sC3iJ04J+vyPYb3H/XXKPA1 xwWJgzfMQ8pUQ3IwXckBlNwzAqne9af8dO735PQjsKi+u1sYnANuhxcgJ+24MEWl6o9Umw HgBJ7WugkOLkvJF/pgib1P2yRxNp+08= X-MC-Unique: lKvKZMCoM4ySp-2AaNFlBg-1 X-Mimecast-MFC-AGG-ID: lKvKZMCoM4ySp-2AaNFlBg_1744114159 To: devel@lists.libvirt.org Subject: [PATCH 1/4] qemu: block: Always assume support for 'block-export-add' Date: Tue, 8 Apr 2025 14:09:12 +0200 Message-ID: <47ce63a7e001fb17fd90e224e9146b4535d354ec.1744114122.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KVTnOqU8w_XWAblx6vp0B4cnkpIyOh5Cekn8G5KLEa4_1744114159 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: LVPWG6FVMFKH6TJ75C4KWIMUUC2HI5LL X-Message-ID-Hash: LVPWG6FVMFKH6TJ75C4KWIMUUC2HI5LL X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1744114190914019100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa 'block-export-add' QMP command which replaces 'nbd-server-add' was introduced in qemu-5.2. We can thus drop the old code now. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 3ed279af28..27ef1b8375 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -3642,9 +3642,6 @@ qemuBlockExportGetNBDProps(const char *nodename, * @writable: whether the NBD export allows writes * @bitmap: (optional) block dirty bitmap to export along * - * This function automatically selects the proper invocation of exporting a - * block backend via NBD in qemu. - * * This function must be called while in the monitor context. */ int @@ -3658,10 +3655,6 @@ qemuBlockExportAddNBD(virDomainObj *vm, g_autoptr(virJSONValue) nbdprops =3D NULL; const char *bitmaps[2] =3D { bitmap, NULL }; - if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCK_EXPORT_ADD)) - return qemuMonitorNBDServerAdd(priv->mon, qemuBlockStorageSourceGe= tEffectiveNodename(src), - exportname, writable, bitmap); - if (!(nbdprops =3D qemuBlockExportGetNBDProps(qemuBlockStorageSourceGe= tEffectiveNodename(src), exportname, writable, bitm= aps))) return -1; --=20 2.49.0