From nobody Mon Feb 9 19:53:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1622812353; cv=none; d=zohomail.com; s=zohoarc; b=boeinEoRzaofhUbqLGeg8yCohg5HsdOB50RX9DFjErt1x5Ul8Az/cTN/kDjd0ckxiIA2dC96MKOq610vzepalD5ljkOhABGKf+uhgM1dvPqypRK2h7IkbLgMN3Rrr50RSAinqLqlZ/bjWhK1+k/mAcOSq1YSp9LCEIstDjybCXM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622812353; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FedIxccGXBCZurYXavkQmzEpluvv6LoPzJYH4In5/sQ=; b=VU82vE5tAfDmIEhNYH+MxT8KH8AzbmeH9oB+bjaJsOTGfNBj7OkjotJRqPzd+4G1K5dPphN6+UcyT4UCCN29T8Dk2+BIzA4H7PKGJ5Bmy9Icxz1EbM8wP92ZTEBTSzdQR43B7JNuOQvu8BGP0NY1lA/onEkSMlr7Py8gvhu7sIk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1622812353920961.6824797720448; Fri, 4 Jun 2021 06:12:33 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-187-2hhJvvJZPlqr9CwYZuJoTg-1; Fri, 04 Jun 2021 09:12:30 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E188501E0; Fri, 4 Jun 2021 13:12:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 717D010023AB; Fri, 4 Jun 2021 13:12:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3AF464ED79; Fri, 4 Jun 2021 13:12:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 154DAsXW026551 for ; Fri, 4 Jun 2021 09:10:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9F8875C26D; Fri, 4 Jun 2021 13:10:54 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 242065C1C5 for ; Fri, 4 Jun 2021 13:10:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622812352; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=FedIxccGXBCZurYXavkQmzEpluvv6LoPzJYH4In5/sQ=; b=iQsVJrZYhTbTG526WwshbQaEDLmDxdaIvWiBHb42ZkjOmlY+tKcMNx8qUn1d9rULFwLxcd oMYb0uJXY5whDqgsKOysdWfsFtMY3g/Ay1dV+h7kwsJC/bxSJPKKOivpEuk65e5vKeGFpe x5YK8jCr+i5XB3ox2jglBvOo04Cmpwo= X-MC-Unique: 2hhJvvJZPlqr9CwYZuJoTg-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 5/6] chExtractVersion: use g_auto* Date: Fri, 4 Jun 2021 15:10:44 +0200 Message-Id: <477b5135b01526bfebe6802caf1898c2902f2e63.1622812176.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" There are two variables that can be freed automatically: @cmd (which allows us to drop explicit virCommandFree() call at the end of the function) and @help which was never freed (and thus leaked). Signed-off-by: Michal Privoznik --- src/ch/ch_conf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/ch/ch_conf.c b/src/ch/ch_conf.c index b2812de7ad..c67c815d45 100644 --- a/src/ch/ch_conf.c +++ b/src/ch/ch_conf.c @@ -196,10 +196,10 @@ chExtractVersion(virCHDriver *driver) { int ret =3D -1; unsigned long version; - char *help =3D NULL; + g_autofree char *help =3D NULL; char *tmp =3D NULL; g_autofree char *ch_cmd =3D g_find_program_in_path(CH_CMD); - virCommand *cmd =3D NULL; + g_autoptr(virCommand) cmd =3D NULL; =20 if (!ch_cmd) return -2; @@ -236,6 +236,5 @@ chExtractVersion(virCHDriver *driver) ret =3D 0; =20 cleanup: - virCommandFree(cmd); return ret; } --=20 2.31.1