[libvirt] [PATCH] news: document spice rendernode DAC changes

Cole Robinson posted 1 patch 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/47460359238b1831693eb06c9fd8b15c16e0caa3.1505234270.git.crobinso@redhat.com
Test syntax-check passed
docs/news.xml | 11 +++++++++++
1 file changed, 11 insertions(+)
[libvirt] [PATCH] news: document spice rendernode DAC changes
Posted by Cole Robinson 6 years, 6 months ago
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 docs/news.xml | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 483f9d6d1..17f00a25e 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -37,6 +37,17 @@
     <section title="New features">
     </section>
     <section title="Improvements">
+      <change>
+        <summary>
+          qemu: DAC permissions properly set for spice renderndoe
+        </summary>
+        <description>
+          When a rendernode= path is set for spice GL on qemu:///system,
+          we now correctly set DAC permissions on the device at VM startup.
+          This is the last remaining hurdle to let spice GL work for
+          qemu:///system without any external host changes.
+        </description>
+      </change>
     </section>
     <section title="Bug fixes">
     </section>
-- 
2.13.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] news: document spice rendernode DAC changes
Posted by Andrea Bolognani 6 years, 6 months ago
On Tue, 2017-09-12 at 12:37 -0400, Cole Robinson wrote:
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  docs/news.xml | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index 483f9d6d1..17f00a25e 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -37,6 +37,17 @@
>      <section title="New features">
>      </section>
>      <section title="Improvements">
> +      <change>
> +        <summary>
> +          qemu: DAC permissions properly set for spice renderndoe

I would shuffle the words around a bit:

  qemu: Set DAC permissions properly for SPICE rendernodes

Also note the 'renderndoe' typo.

> +        </summary>
> +        <description>
> +          When a rendernode= path is set for spice GL on qemu:///system,
> +          we now correctly set DAC permissions on the device at VM startup.
> +          This is the last remaining hurdle to let spice GL work for
> +          qemu:///system without any external host changes.

s/spice/SPICE/g

I also suggest wrapping 'rendernode' and qemu:///system in <code>
elements to make them look better in the HTML version.

With those addressed,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list