From nobody Mon Feb 9 10:50:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626864431; cv=none; d=zohomail.com; s=zohoarc; b=WiE5t+ZHLkXewcoBFJvBWvnaxQd4EsOEc2slaSimpCJjx0paqVE4b3rAWSWDYzSOhieTjTTP62qlJRDSTdFUCWCGZmCeFkDZU0RflL1mBVlUJwpp294KecCZjKnmW8U5xjWP3YjMbRPcx7FXWVeLv1dvZu60lNuy1Sohk3vz0kU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626864431; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5NjszG/tl1d+jklDrpQj7yBBRC6Tc6+CCoTV7+RW48k=; b=PXrSBCfO41uGq2vJ9llykRps20sMsN9qVkJtSbgmrRHp0NkuQKad2zz+CsA89FZWEd+MS+2RfYhemH92YSx4IRFKAmOg1tN0jE9RmuRAvK5ObmxvDWTCjpiHcUWNYj/mTMx9Kqkd0m6dHOAkxiLu4bcGgBSVxXbzmPS+t6sYvWs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 162686443140754.76802355840846; Wed, 21 Jul 2021 03:47:11 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-530-y76kEtNjMpeWpgCoRctPyw-1; Wed, 21 Jul 2021 06:46:05 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 08C87A0BE7; Wed, 21 Jul 2021 10:46:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE0201B5C2; Wed, 21 Jul 2021 10:45:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A91E55003C; Wed, 21 Jul 2021 10:45:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16LAhDri000954 for ; Wed, 21 Jul 2021 06:43:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id 316AE19C79; Wed, 21 Jul 2021 10:43:13 +0000 (UTC) Received: from andariel.local (unknown [10.40.193.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 925DE19D9B for ; Wed, 21 Jul 2021 10:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626864430; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=5NjszG/tl1d+jklDrpQj7yBBRC6Tc6+CCoTV7+RW48k=; b=gU67vV43yZ4BnuaEzP61CrKGGutsE2Xjr0Uk8xSNLJQ2oJ/mtHmujRoEe7p9iUHlSq0hkS 3wHnYvvsEItteSXd8Agg36q6WTHy13Ki/RKi6xqUGWL4VAEgNWI5g6lFlCB6G/Y5RQiOx5 eIdnCrtPW8IK+1PXCHKykmGD811LCt8= X-MC-Unique: y76kEtNjMpeWpgCoRctPyw-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 19/33] qemu: Remove return value from qemuMonitorDomainGuestPanicCallback Date: Wed, 21 Jul 2021 12:42:31 +0200 Message-Id: <4732a058e9b77878061e520598bb0e5315e716c0.1626864131.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626864433398100001 Content-Type: text/plain; charset="utf-8" Change the callback prototype and fix the callback registered in the process code. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.h | 8 ++++---- src/qemu/qemu_process.c | 4 +--- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 2cfcd40ab8..76e87d5909 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -234,10 +234,10 @@ typedef void (*qemuMonitorDomainBalloonChangeCallback= )(qemuMonitor *mon, typedef void (*qemuMonitorDomainPMSuspendDiskCallback)(qemuMonitor *mon, virDomainObj *vm, void *opaque); -typedef int (*qemuMonitorDomainGuestPanicCallback)(qemuMonitor *mon, - virDomainObj *vm, - qemuMonitorEventPanicIn= fo *info, - void *opaque); +typedef void (*qemuMonitorDomainGuestPanicCallback)(qemuMonitor *mon, + virDomainObj *vm, + qemuMonitorEventPanicI= nfo *info, + void *opaque); typedef int (*qemuMonitorDomainDeviceDeletedCallback)(qemuMonitor *mon, virDomainObj *vm, const char *devAlias, diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index ef0b9a4503..cf77b7448c 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1268,7 +1268,7 @@ qemuProcessHandlePMSuspendDisk(qemuMonitor *mon G_GNU= C_UNUSED, } -static int +static void qemuProcessHandleGuestPanic(qemuMonitor *mon G_GNUC_UNUSED, virDomainObj *vm, qemuMonitorEventPanicInfo *info, @@ -1294,8 +1294,6 @@ qemuProcessHandleGuestPanic(qemuMonitor *mon G_GNUC_U= NUSED, } virObjectUnlock(vm); - - return 0; } --=20 2.31.1