From nobody Sat Feb 7 08:53:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568015398; cv=none; d=zoho.com; s=zohoarc; b=VKSqKrRdCahsp7+xMzkhiePyT7pP+cU3Qxg0zOGWB+kQcGo4YUlNwTKVLuH9z8spIf7JTq4QSMwJ1/x0mn19+wEAPVnHiNndkAX1koXodAY/SftuXxzJcX25mHuOYVYrsEITLj5wU0NCL+gat5Pnw/c+SlIIF0yyiBCz7r+ucmg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568015398; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=wsrxwMM+w0+3+8iSsMDuB5+bAf1XZiccm/qqGAi/tQ8=; b=OKOZbsRWEMqi6q9sZhiZT6cRzURwbXcV0LSPbmsAurbLbkjWRakdtG72n3Yt3TdYZ1+ot4hCRnSE41XS4ZQbFRirvyOEyglZVxcnC6tKIo+2xvtG2Yb1HcrK9ctB06etnmv5ZQQqllNKdC393UtAwBUCq5kllRYqHMCTaUS+iXA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1568015398401300.54475880124266; Mon, 9 Sep 2019 00:49:58 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3E74B300BC7E; Mon, 9 Sep 2019 07:49:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 38F335D6A7; Mon, 9 Sep 2019 07:49:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8D7C04A486; Mon, 9 Sep 2019 07:49:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x897nljp004843 for ; Mon, 9 Sep 2019 03:49:47 -0400 Received: by smtp.corp.redhat.com (Postfix) id A861E5D6B7; Mon, 9 Sep 2019 07:49:47 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 32E5A5D6A7 for ; Mon, 9 Sep 2019 07:49:47 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Mon, 9 Sep 2019 09:49:39 +0200 Message-Id: <4710592f0158dbbbe6a24be39e43faa6b4264e4e.1568015323.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/4] configure: Prefer LIBVIRT_RESULT over AC_MSG_NOTICE X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 09 Sep 2019 07:49:56 +0000 (UTC) Content-Type: text/plain; charset="utf-8" One of the advantages is that LIBVIRT_RESULT aligns the resulting message for us. The other is that in near future we will colour some parts of the message and thus it helps if we get arguments split in two. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- configure.ac | 8 ++++---- m4/virt-chrdev-lock-files.m4 | 2 +- m4/virt-debug.m4 | 2 +- m4/virt-default-editor.m4 | 2 +- m4/virt-dtrace.m4 | 2 +- m4/virt-host-validate.m4 | 2 +- m4/virt-init-script.m4 | 2 +- m4/virt-loader-nvram.m4 | 2 +- m4/virt-login-shell.m4 | 2 +- m4/virt-numad.m4 | 2 +- 10 files changed, 13 insertions(+), 13 deletions(-) diff --git a/configure.ac b/configure.ac index bf9e7681bc..a8f8b0517e 100644 --- a/configure.ac +++ b/configure.ac @@ -1047,14 +1047,14 @@ LIBVIRT_WIN_RESULT_WINDRES AC_MSG_NOTICE([]) AC_MSG_NOTICE([Test suite]) AC_MSG_NOTICE([]) -AC_MSG_NOTICE([ Coverage: $enable_test_coverage]) -AC_MSG_NOTICE([ Alloc OOM: $enable_test_oom]) +LIBVIRT_RESULT([Coverage], [$enable_test_coverage]) +LIBVIRT_RESULT([Alloc OOM], [$enable_test_oom]) AC_MSG_NOTICE([]) AC_MSG_NOTICE([Miscellaneous]) AC_MSG_NOTICE([]) LIBVIRT_RESULT_DEBUG -AC_MSG_NOTICE([ Use -Werror: $enable_werror]) -AC_MSG_NOTICE([ Warning Flags: $WARN_CFLAGS]) +LIBVIRT_RESULT([Use -Werror], [$enable_werror]) +LIBVIRT_RESULT([Warning Flags], [$WARN_CFLAGS]) LIBVIRT_RESULT_DTRACE LIBVIRT_RESULT_NUMAD LIBVIRT_RESULT_INIT_SCRIPT diff --git a/m4/virt-chrdev-lock-files.m4 b/m4/virt-chrdev-lock-files.m4 index 7d85c0e21b..5802136b9f 100644 --- a/m4/virt-chrdev-lock-files.m4 +++ b/m4/virt-chrdev-lock-files.m4 @@ -48,5 +48,5 @@ AC_DEFUN([LIBVIRT_CHECK_CHRDEV_LOCK_FILES], [ ]) =20 AC_DEFUN([LIBVIRT_RESULT_CHRDEV_LOCK_FILES], [ - AC_MSG_NOTICE([ Char device locks: $with_chrdev_lock_files]) + LIBVIRT_RESULT([Char device locks], [$with_chrdev_lock_files]) ]) diff --git a/m4/virt-debug.m4 b/m4/virt-debug.m4 index d03cf10255..d3ac0564f2 100644 --- a/m4/virt-debug.m4 +++ b/m4/virt-debug.m4 @@ -29,5 +29,5 @@ AC_DEFUN([LIBVIRT_CHECK_DEBUG], [ ]) =20 AC_DEFUN([LIBVIRT_RESULT_DEBUG], [ - AC_MSG_NOTICE([ Debug: $enable_debug]) + LIBVIRT_RESULT([Debug], [$enable_debug]) ]) diff --git a/m4/virt-default-editor.m4 b/m4/virt-default-editor.m4 index 0c8e1e0798..4b4cad4e87 100644 --- a/m4/virt-default-editor.m4 +++ b/m4/virt-default-editor.m4 @@ -28,5 +28,5 @@ AC_DEFUN([LIBVIRT_CHECK_DEFAULT_EDITOR], [ ]) =20 AC_DEFUN([LIBVIRT_RESULT_DEFAULT_EDITOR], [ - AC_MSG_NOTICE([ Default Editor: $with_default_editor]) + LIBVIRT_RESULT([Default Editor], [$with_default_editor]) ]) diff --git a/m4/virt-dtrace.m4 b/m4/virt-dtrace.m4 index e072b639cd..3dc20d5343 100644 --- a/m4/virt-dtrace.m4 +++ b/m4/virt-dtrace.m4 @@ -41,5 +41,5 @@ AC_DEFUN([LIBVIRT_CHECK_DTRACE], [ ]) =20 AC_DEFUN([LIBVIRT_RESULT_DTRACE], [ - AC_MSG_NOTICE([ DTrace: $with_dtrace]) + LIBVIRT_RESULT([DTrace], [$with_dtrace]) ]) diff --git a/m4/virt-host-validate.m4 b/m4/virt-host-validate.m4 index 643cd8f06e..e43cec5366 100644 --- a/m4/virt-host-validate.m4 +++ b/m4/virt-host-validate.m4 @@ -39,5 +39,5 @@ AC_DEFUN([LIBVIRT_CHECK_HOST_VALIDATE], [ ]) =20 AC_DEFUN([LIBVIRT_RESULT_HOST_VALIDATE], [ - AC_MSG_NOTICE([virt-host-validate: $with_host_validate]) + LIBVIRT_RESULT([virt-host-validate], [$with_host_validate]) ]) diff --git a/m4/virt-init-script.m4 b/m4/virt-init-script.m4 index 91bbd68235..6eb81f0429 100644 --- a/m4/virt-init-script.m4 +++ b/m4/virt-init-script.m4 @@ -51,5 +51,5 @@ AC_DEFUN([LIBVIRT_CHECK_INIT_SCRIPT],[ ]) =20 AC_DEFUN([LIBVIRT_RESULT_INIT_SCRIPT],[ - AC_MSG_NOTICE([ Init script: $with_init_script]) + LIBVIRT_RESULT([Init script], [$with_init_script]) ]) diff --git a/m4/virt-loader-nvram.m4 b/m4/virt-loader-nvram.m4 index 0eb77fa923..d7e0c8ca18 100644 --- a/m4/virt-loader-nvram.m4 +++ b/m4/virt-loader-nvram.m4 @@ -37,5 +37,5 @@ AC_DEFUN([LIBVIRT_CHECK_LOADER_NVRAM], [ ]) =20 AC_DEFUN([LIBVIRT_RESULT_LOADER_NVRAM], [ - AC_MSG_NOTICE([ Loader/NVRAM: $with_loader_nvram]) + LIBVIRT_RESULT([Loader/NVRAM], [$with_loader_nvram]) ]) diff --git a/m4/virt-login-shell.m4 b/m4/virt-login-shell.m4 index 3baec5432f..713c488599 100644 --- a/m4/virt-login-shell.m4 +++ b/m4/virt-login-shell.m4 @@ -39,5 +39,5 @@ AC_DEFUN([LIBVIRT_CHECK_LOGIN_SHELL], [ ]) =20 AC_DEFUN([LIBVIRT_RESULT_LOGIN_SHELL], [ - AC_MSG_NOTICE([ virt-login-shell: $with_login_shell]) + LIBVIRT_RESULT([virt-login-shell], [$with_login_shell]) ]) diff --git a/m4/virt-numad.m4 b/m4/virt-numad.m4 index e760dcc579..378eba3c97 100644 --- a/m4/virt-numad.m4 +++ b/m4/virt-numad.m4 @@ -54,5 +54,5 @@ AC_DEFUN([LIBVIRT_CHECK_NUMAD], [ ]) =20 AC_DEFUN([LIBVIRT_RESULT_NUMAD], [ - AC_MSG_NOTICE([ numad: $with_numad]) + LIBVIRT_RESULT([numad], [$with_numad]) ]) --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list