From nobody Fri Oct 18 06:15:20 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1706019634639874.6403767568053; Tue, 23 Jan 2024 06:20:34 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 7708C19E6; Tue, 23 Jan 2024 09:20:33 -0500 (EST) Received: from lists.libvirt.org.85.43.8.in-addr.arpa (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id CF37C190A; Tue, 23 Jan 2024 09:19:07 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id BEECD18FE; Tue, 23 Jan 2024 09:19:03 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 6772E18A3 for ; Tue, 23 Jan 2024 09:19:02 -0500 (EST) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-oFcmMUeNPSymF9ywEK9xjQ-1; Tue, 23 Jan 2024 09:19:00 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D8B4229AC015 for ; Tue, 23 Jan 2024 14:18:59 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id 06F1051D5; Tue, 23 Jan 2024 14:18:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: oFcmMUeNPSymF9ywEK9xjQ-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 1/6] virschematest: Don't bother checking symlinked XMLs Date: Tue, 23 Jan 2024 15:18:43 +0100 Message-ID: <4602e03ea97d287529128173f44a31b842c52a44.1706017336.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: KVIAVLU42SEOIHRUZN7OVM2KPXCAVT76 X-Message-ID-Hash: KVIAVLU42SEOIHRUZN7OVM2KPXCAVT76 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: abologna@redhat.com X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1706019636276100001 There's plenty symlinks in qemuxml2argvdata and qemuxml2xmlout directories pointing to other files in the same directory. It makes no sense to check those files twice, thus we can simply skip symlinks. Signed-off-by: Peter Krempa --- tests/virschematest.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/virschematest.c b/tests/virschematest.c index 1d122a9bc9..1e911cd68e 100644 --- a/tests/virschematest.c +++ b/tests/virschematest.c @@ -118,11 +118,15 @@ testSchemaDir(const char *schema, while ((rc =3D virDirRead(dir, &ent, dir_path)) > 0) { g_autofree char *xml_path =3D NULL; bool exception =3D false; + GStatBuf sb; if (!virStringHasSuffix(ent->d_name, ".xml")) continue; if (ent->d_name[0] =3D=3D '.') continue; + if (g_lstat(ent->d_name, &sb) >=3D 0 && + S_ISLNK(sb.st_mode)) + continue; if (filter && !g_regex_match(filter, ent->d_name, 0, NULL)) continue; --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org