From nobody Mon Feb 9 13:02:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1628075124; cv=none; d=zohomail.com; s=zohoarc; b=PNYpDZ3+UsEwuk7L8HMABXQmEoOBp7eZl86vAaiUyWoCh45DQMfw2PLPv0hyPo1wccn4cO3OlEd2A/alC+2asq/7sYoUI0WP9OTeZ/Za2s/zfAk6o2iEIjXy++qk3CRiejWexcBrRbiCyl2udPHCj6cwEVHsDPvAAFxNg6hqVAQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628075124; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rnHx1+yTFCqFhF1nA1k+s1yWDiUKkm/PiVuD+3uKxoY=; b=csNXijIHcfqpWg1iCCAx4pbp+ka5lExAIHwCu+NwxtKJnk7Rqoi7ZGlZCCTqdlPEWEgy18hQFrHcEbrliI1BSRtZ2BhKERjG0edyGxPI9CfFcOU8Ea3oBOkak9Dy5N9bRu6+E58NHjdi6hLuQf10/3RJM2EJbYEhsc9ge7POtwc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1628075124643721.9493978284827; Wed, 4 Aug 2021 04:05:24 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-540-qvNfYh1SNNC1VTfs8XT5Ig-1; Wed, 04 Aug 2021 07:03:54 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 97242363A4; Wed, 4 Aug 2021 11:03:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 79D1260CC4; Wed, 4 Aug 2021 11:03:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 481DC4A71C; Wed, 4 Aug 2021 11:03:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 174B3DtT014326 for ; Wed, 4 Aug 2021 07:03:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id C936C1383C; Wed, 4 Aug 2021 11:03:13 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2778E5D9DC for ; Wed, 4 Aug 2021 11:03:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628075123; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=rnHx1+yTFCqFhF1nA1k+s1yWDiUKkm/PiVuD+3uKxoY=; b=ZVhDLfHK9m+6yNTMtsdCpZxttPog+eaF0/5dyF6yz1t8PovPTVhqmsE90t49c7S6k4vx1r Ctm56hOsleTcbh1/KixmHw+vvEIWfzBOgHDKHdnJDRTv2QpahmY3AmfbsduGd8b90vTEQW wH9m088EIllAbhf0C0ZuzOIAtQUn1ZY= X-MC-Unique: qvNfYh1SNNC1VTfs8XT5Ig-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 19/23] virNetServerGetClients: Remove pointless cleanup Date: Wed, 4 Aug 2021 13:02:39 +0200 Message-Id: <45cb9cfcb469081131f1f2c6058a290fcfd89959.1628074874.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1628075126684100001 Content-Type: text/plain; charset="utf-8" 'list' will always be NULL when reaching 'virObjectListFreeCount' thus we can remove the call as well as the 'ret' variable which was only ever equal to 'nclients' at the point when we returned the value. Signed-off-by: Peter Krempa --- src/rpc/virnetserver.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c index bb1a96b65e..b3214883ee 100644 --- a/src/rpc/virnetserver.c +++ b/src/rpc/virnetserver.c @@ -1077,7 +1077,6 @@ int virNetServerGetClients(virNetServer *srv, virNetServerClient ***clts) { - int ret =3D -1; size_t i; size_t nclients =3D 0; virNetServerClient **list =3D NULL; @@ -1090,11 +1089,10 @@ virNetServerGetClients(virNetServer *srv, } *clts =3D g_steal_pointer(&list); - ret =3D nclients; - virObjectListFreeCount(list, nclients); virObjectUnlock(srv); - return ret; + + return nclients; } virNetServerClient * --=20 2.31.1