From nobody Fri Dec 12 12:55:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1763734716; cv=none; d=zohomail.com; s=zohoarc; b=QBjpqTJ9G7jyCGqwkwEKZTXx4ECy2MgiGt3vaElaybhNNJCFGY9GyNfCBD/icdNlp1w9NWobjNdVls9uKK69D1ymWq7Rpb9ky8+0PJv2jAUS4iy3FIvggaF4UKBG/z4vw6T5Qfe4K1JGk+16rGWMDFDl7wwh7pxDG1CliLs0VNc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763734716; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=GJS/p2IC4gC56AoWj+tAvF4OpNic0QLdbEgSIBv1I8I=; b=QN+PIJwEP59+eU19M2+ym/q65ryqS00YgN/JgwbTWTbU1rPj98Aw6JTHg1xvKmmxDy5NWY+koTrpmnSleTRFK65Q45zzJu/6hQ+33O5tOfDpmyxVe1zMYBX5bG3RqdVTX9SOQoXAFz2toa3uTpLQHSt2J5M3H/GKsj6XlP2qgic= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1763734716248128.04295542103443; Fri, 21 Nov 2025 06:18:36 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 544794415B; Fri, 21 Nov 2025 09:18:32 -0500 (EST) Received: from [172.19.199.56] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 9024C44265; Fri, 21 Nov 2025 09:17:49 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 342E441B25; Fri, 21 Nov 2025 09:16:34 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B91ED41BE3 for ; Fri, 21 Nov 2025 09:16:30 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-rlDDqu4VMqeQL4uZtXiThg-1; Fri, 21 Nov 2025 09:16:29 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 21354195609F for ; Fri, 21 Nov 2025 14:16:28 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 705C11940E8C for ; Fri, 21 Nov 2025 14:16:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763734590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GJS/p2IC4gC56AoWj+tAvF4OpNic0QLdbEgSIBv1I8I=; b=i+bWu/0h4dJUnxsGtHdM9IrogLSuDPF1u7zF7ubnDSko3+LhkA4Mt9xrEPeEg9rlnCy4yn 2LNzdMimN3xiQ1VU3tZfmwN+jEe7R21ayO9/DHYQkhkk/mzGaZQG+UVThHK5aMKdHLP+3U n80fA0yndrltwdEcNnh5S6L0S9P7Vhs= X-MC-Unique: rlDDqu4VMqeQL4uZtXiThg-1 X-Mimecast-MFC-AGG-ID: rlDDqu4VMqeQL4uZtXiThg_1763734588 To: devel@lists.libvirt.org Subject: [PATCH] tests: Don't link vmx2xmltest with esx_lib Date: Fri, 21 Nov 2025 15:16:24 +0100 Message-ID: <451fa2be3ae426a3f99787d243a6f5c5c62c9674.1763734221.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FV-EHZtMhfuv-xUKR5HH2lqDs1y5FS84pFYY6ylMLP0_1763734588 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: Z3UXYVSU6TCFR45J7MEU7D5NCHGX2PYC X-Message-ID-Hash: Z3UXYVSU6TCFR45J7MEU7D5NCHGX2PYC X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1763734720105018900 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik When reworking the vmx2xmltest to call esxParseVMXFileName() from the ESX driver I also made the test link with the driver statically. But the function then calls some other functions which are mocked in vmx2xmlmock. Now, on many systems this works just fine as the dynamic linker finds the mocked functions first. But on Fedora 41 and Fedora 42 the dynamic linker resolves the symbols to those from statically linked library rendering our mock ineffective. Just don't link in the esx_lib. Fixes: f82d30307da8bea396a32dcab2ba9be5c3236b7c Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- Green pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/2172179136 tests/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/meson.build b/tests/meson.build index 1f25f674f4..bb6ee6b4ee 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -550,7 +550,7 @@ endif =20 if conf.has('WITH_VMX') and conf.has('WITH_ESX') tests +=3D [ - { 'name': 'vmx2xmltest', 'include': [ esx_inc_dir ], 'link_with': [ es= x_lib ] }, + { 'name': 'vmx2xmltest', 'include': [ esx_inc_dir ] }, { 'name': 'xml2vmxtest' }, ] mock_libs +=3D [ --=20 2.51.0