From nobody Tue Sep 9 19:12:41 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747671812; cv=none; d=zohomail.com; s=zohoarc; b=fFSOmQUKIYxSF+ash25+Ar9vycGqcGA2pD3T9hI9024FwGDy2AvHS6XIizVKhqsOXm7JD9itQLyfFPtSd3Ukc2+ntSt4x6z/K6a1np94tEO2bpBAl8t/dMEp6Cwp9ujqNOARllAxwp+pibNbqeSbqQPRCgfRKasBAG1QHFfMuA4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747671812; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=7sIJ/QLGRzT12C7CSE9qM3LDFAyox7PWHwzcykmf7Cg=; b=fOmmpBP1z+aYNe9/XdReLtel4qPGcW9kAL2x0vd6NfZtjnbm1mvLi9UYFul7/+BXEvGnYAagQmi05xw2uSWIVXGhDjT1lWcwq78+ivwQkxl0Kk4XDMc0vuM27J3wqmGTo+dZ+CiTbXMguOrPf67baP2BwM3gcsuiUXctQQFNirM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747671812873171.00840062312648; Mon, 19 May 2025 09:23:32 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id DD788169C; Mon, 19 May 2025 12:23:31 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id CF77C1564; Mon, 19 May 2025 12:23:13 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 23C89152D; Mon, 19 May 2025 12:23:11 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 6260414F5 for ; Mon, 19 May 2025 12:23:10 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-OcDV1DdvPuSHjb3dPe3KHw-1; Mon, 19 May 2025 12:23:08 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A7DBD1955E94 for ; Mon, 19 May 2025 16:23:07 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.224.76]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AA4891955E72 for ; Mon, 19 May 2025 16:23:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747671790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ffhFcrXi0dZpvI6DMjePclNn3UT4bw7u+ExcCLYLjVM=; b=bKlTHEcErAuFtgwmaKj4a1e0AgnRfc/dbOnNwC5rEIDbfJQfZ1+45t2kww4y/s6OzVDIUE p3sPSyKLcXWIaCNI7kQKtMwarNsa+xty8BLuN5u0Z6ICRLvacZxD95g8kGr9+AxpniAp+B x1yaZNKhuBI17UJ0+dgmgu8UzgNBnJw= X-MC-Unique: OcDV1DdvPuSHjb3dPe3KHw-1 X-Mimecast-MFC-AGG-ID: OcDV1DdvPuSHjb3dPe3KHw_1747671788 To: devel@lists.libvirt.org Subject: [libvirt PATCH] qemu: forbid readonly attribute for externally launched virtiofsd Date: Mon, 19 May 2025 18:22:44 +0200 Message-ID: <43ba1403d6e0d7430fadb3949d53f5f5230cfa0f.1747671764.git.jtomko@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WWHQMyZagcRhgOBelLVoT8oc9JCA5V5lmVdzEH-koL8_1747671788 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: NL4CQGJFVAELX5OCEBMEWMW4JPV46ROA X-Message-ID-Hash: NL4CQGJFVAELX5OCEBMEWMW4JPV46ROA X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?J=C3=A1n_Tomko_via_Devel?= Reply-To: =?UTF-8?q?J=C3=A1n=20Tomko?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747671815545116600 Content-Type: text/plain; charset="utf-8" From: J=C3=A1n Tomko In that case, libvirtd cannot set it on the command line because virtiofsd is not launched by libvirt. https://issues.redhat.com/browse/RHEL-87522 Signed-off-by: J=C3=A1n Tomko Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_validate.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 87588024ce..013ff14d75 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -4684,6 +4684,11 @@ qemuValidateDomainDeviceDefFS(virDomainFSDef *fs, _("virtiofs does not support wrpolicy")); return -1; } + if (fs->readonly) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("readonly mode cannot be set for extrenal= ly started virtiofsd")); + return -1; + } } =20 if (fs->model !=3D VIR_DOMAIN_FS_MODEL_DEFAULT) { --=20 2.49.0