From nobody Mon Sep 16 19:13:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1719580220113746.2245212875673; Fri, 28 Jun 2024 06:10:20 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id DCC4312A0; Fri, 28 Jun 2024 09:10:18 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 4A57012B2; Fri, 28 Jun 2024 09:09:59 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id BBD151256; Fri, 28 Jun 2024 09:09:55 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 5BED31251 for ; Fri, 28 Jun 2024 09:09:55 -0400 (EDT) Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-88-7LTSUJXhNGiAA_ptqkVAOQ-1; Fri, 28 Jun 2024 09:09:53 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BA1831945110 for ; Fri, 28 Jun 2024 13:09:52 +0000 (UTC) Received: from ajulis-thinkpadt14gen4.remote.csb (unknown [10.67.24.181]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B120A300021A for ; Fri, 28 Jun 2024 13:09:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719580195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+5Kd1f+45qawhYpn+rK6tu00NoRj2H9n4wbSQHLd+PM=; b=CWZTEeAzrWFTdgahvbWMsLrC9r/IuPPWMAozR1fzaYCX9aYXtOol4BDquwmKNRSQ1YeVH6 Os1Vi4DjAg0UM7KZ6FXwWH3bATUlFwD8D5EUEexXk23nqkbPJBDtevnRk78p5XuzFllVi8 6ORuNUnBq8MtTN1P0DuJYAzLsILoFd0= X-MC-Unique: 7LTSUJXhNGiAA_ptqkVAOQ-1 From: Adam Julis To: devel@lists.libvirt.org Subject: [PATCH] qemuDomainChangeNet: forbid changing portgroup Date: Fri, 28 Jun 2024 15:07:26 +0200 Message-ID: <43502fd93d323c395bd649baf20e3b510d232ce4.1719580019.git.ajulis@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: L6JI6KDNHC24ZLVTSFWNDDR4TBO4QHDR X-Message-ID-Hash: L6JI6KDNHC24ZLVTSFWNDDR4TBO4QHDR X-MailFrom: ajulis@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1719580222013100001 Content-Type: text/plain; charset="utf-8"; x-default="true" While changing the portgroup attribute causes incorrect behavior, this option is disabled for hot-plug. Resolves: https://issues.redhat.com/browse/RHEL-7299 Signed-off-by: Adam Julis --- src/qemu/qemu_hotplug.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 4a3f4f657e..355f742535 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3884,6 +3884,13 @@ qemuDomainChangeNet(virQEMUDriver *driver, goto cleanup; } =20 + if (newdev->type =3D=3D VIR_DOMAIN_NET_TYPE_NETWORK && + STRNEQ_NULLABLE(olddev->data.network.portgroup, newdev->data.netwo= rk.portgroup)) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("cannot modify network device portgroup attribute= ")); + goto cleanup; + } + /* allocate new actual device to compare to old - we will need to * free it if we fail for any reason */ --=20 2.45.2