From nobody Mon Feb 9 11:17:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1742486853; cv=none; d=zohomail.com; s=zohoarc; b=QBcAUrFhWeCkj1Xps72UNlUSeLYbUsl+MdmqgsAwV1WnuEj8lQny2wkQMEMcNhNnPkpsriziqakNUgiGUQgLzmjqD1kY8HMj21d01YL0bO0rTwxBryrTuvFNkg/6fvHBGTLeDzjLi1ETmINuAmaWbRd4tsP+O2j/1wmr09b2QSc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742486853; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=0oJfIyoUKsoYP3dnnyRDlO9WUeo9+FeQex/vduEqP6w=; b=OxhRukc37MBSloShCKT+afro6dMoG1oLaOfoFGEsYZgatboI3YTk2R9WU+w0hdpwbCKv93rVUKZM9pF2I/j9As9X0viMEL3SPWzF/UPbRp/tg5k1B5Qjm1DbFTb/HL3KRapS9+uMx7I4iq5GRBFNtPQw1MdhXyTkessByh/2dPY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1742486853826443.8865793316802; Thu, 20 Mar 2025 09:07:33 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id DC78C1274; Thu, 20 Mar 2025 12:07:32 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 7687C173E; Thu, 20 Mar 2025 12:04:51 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id BC42E15D2; Thu, 20 Mar 2025 12:04:37 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 10AEA1596 for ; Thu, 20 Mar 2025 12:04:19 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-259-56dO2uLLO8uFl7EBWSCCrg-1; Thu, 20 Mar 2025 12:04:17 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A0A0E1800259 for ; Thu, 20 Mar 2025 16:04:16 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C749219373C4 for ; Thu, 20 Mar 2025 16:04:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742486658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SxyMP71O2S7E+YBVplA4t5Z3IbiXjdnJhN+71NKI2bk=; b=M98DSv3ACImUuFbamgZD1w0BKtCGUxmRd97kHC60FpzwOjnrf4UWW7fDyDCPijfJKJoHVG 8PG/8oTxCu5MfFeckUdBeSuQIjfzBAGE0QfVDJvd2nd+7qwNuvuowBe0pLOdOvSWXG4RrG sOKeoU+2QpMcAEydNwv8ig56xZFJkNg= X-MC-Unique: 56dO2uLLO8uFl7EBWSCCrg-1 X-Mimecast-MFC-AGG-ID: 56dO2uLLO8uFl7EBWSCCrg_1742486656 To: devel@lists.libvirt.org Subject: [PATCH 6/8] qemuAgentCheckError: Use 'VIR_ERR_AGENT_COMMAND_FAILED' Date: Thu, 20 Mar 2025 17:04:03 +0100 Message-ID: <427364ccdef866d78245b0ca5c383eed1c0a8b9b.1742486492.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zH8SPQN9wOLjK91Y9T5IoSkiZcQxKUkzlC54aNBpgso_1742486656 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KOKYPXCQIXBLDXC7O4L2FUIRG4L25HLS X-Message-ID-Hash: KOKYPXCQIXBLDXC7O4L2FUIRG4L25HLS X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1742486856071019100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa In the two cases when we know that the command returned failure switch to the new error code so that management applications can programatically detect failure of the guest agent command. Signed-off-by: Peter Krempa --- src/qemu/qemu_agent.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index b22c9d7e85..d4eb4897a4 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -985,7 +985,7 @@ qemuAgentCheckError(virJSONValue *cmd, /* Only send the user the command name + friendly error */ if (!error) { - virReportError(VIR_ERR_INTERNAL_ERROR, + virReportError(VIR_ERR_AGENT_COMMAND_FAILED, _("unable to execute QEMU agent command '%1$s'"= ), qemuAgentCommandName(cmd)); return -1; @@ -999,7 +999,7 @@ qemuAgentCheckError(virJSONValue *cmd, return -2; } - virReportError(VIR_ERR_INTERNAL_ERROR, + virReportError(VIR_ERR_AGENT_COMMAND_FAILED, _("unable to execute QEMU agent command '%1$s': %2$= s"), qemuAgentCommandName(cmd), qemuAgentStringifyError(error)); --=20 2.48.1