From nobody Fri May 3 14:48:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575848341; cv=none; d=zohomail.com; s=zohoarc; b=eMs6hSwA2NNK9b3YzZKAelPqd8V3TbxcksH40zXwPtGrnOwtgw4oXRSvCSf8HStD2Cr7C1UH1rc5cYv8XVl+AUsLPbISCAVnzgEwqIkdA/HDnCZGW/wCjSdzfbliYr2hBAgmRRKOBOyVO7fvc0tGPn0KHRVx/tovyIpKJIXJT5U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575848341; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=GmWa0jx684NhWn9FiEv0sxeJQviKl5x6YLfuLOVRr7g=; b=UZPkDSSc8jE2AgnrrDnLQ9KECmY0nN4qtekuYkAjWXwcQvykY+u+PEYSq19Iz/IRYEIkMCILgBfP74ovazDoLZDuX7ErlvjQiQ0rj+gmwA869Z2A8ViErQQj7vAiu/WaEcKSQVZ3bS70h3Px3AnuPZo7zlp3WMG/5S99Waj/uLc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1575848341671424.7807360322688; Sun, 8 Dec 2019 15:39:01 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230-ql0FiCzePcKPGsOKzL1W3g-1; Sun, 08 Dec 2019 18:38:58 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D783801E74; Sun, 8 Dec 2019 23:38:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0152960BEC; Sun, 8 Dec 2019 23:38:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B7CEB18089CE; Sun, 8 Dec 2019 23:38:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xB8Ncp5Z016901 for ; Sun, 8 Dec 2019 18:38:51 -0500 Received: by smtp.corp.redhat.com (Postfix) id 75AEC60484; Sun, 8 Dec 2019 23:38:51 +0000 (UTC) Received: from worklaptop.redhat.com (ovpn-120-182.rdu2.redhat.com [10.10.120.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC656600D3; Sun, 8 Dec 2019 23:38:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575848340; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=GmWa0jx684NhWn9FiEv0sxeJQviKl5x6YLfuLOVRr7g=; b=GLHVzNKDBfZN7r3tqs5Ad3/f21/Fg0x6wM0CUpi3nHMiRcbjyC1tSo9SEBX5XsPEtivtu1 5eZ1oRUxzZlhNNbG8xrasF6iw7scsDkMqH2RrQFkmCF5colD9Rdg465prQFkw29DtsxIFX LQ9niBvNWOLqxRrQRMsv3JAYQoqdbrc= From: Cole Robinson To: libvirt-list@redhat.com Date: Sun, 8 Dec 2019 18:40:05 -0500 Message-Id: <425bd547c5348dc28f885a70fed0a94a0c4e028b.1575848405.git.crobinso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Cole Robinson Subject: [libvirt] [PATCH] qemu: checkpoint: fix NULL dereference at create time X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: ql0FiCzePcKPGsOKzL1W3g-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" 'cfg' is never initialized here, which causes a crash later in qemuCheckpointCreateFinalize Signed-off-by: Cole Robinson Reviewed-by: Peter Krempa --- src/qemu/qemu_checkpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c index d5af6b99bf..58cf337833 100644 --- a/src/qemu/qemu_checkpoint.c +++ b/src/qemu/qemu_checkpoint.c @@ -468,7 +468,7 @@ qemuCheckpointCreateXML(virDomainPtr domain, bool update_current =3D true; bool redefine =3D flags & VIR_DOMAIN_CHECKPOINT_CREATE_REDEFINE; unsigned int parse_flags =3D 0; - g_autoptr(virQEMUDriverConfig) cfg =3D NULL; + g_autoptr(virQEMUDriverConfig) cfg =3D virQEMUDriverGetConfig(driver); g_autoptr(virCaps) caps =3D NULL; g_autoptr(virDomainCheckpointDef) def =3D NULL; =20 --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list