From nobody Sat Nov 23 08:15:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1731671556733980.0249493730489; Fri, 15 Nov 2024 03:52:36 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 8F40119F5; Fri, 15 Nov 2024 06:52:35 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 4B7341A09; Fri, 15 Nov 2024 06:52:21 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 595171972; Fri, 15 Nov 2024 06:52:18 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id CCAF31668 for ; Fri, 15 Nov 2024 06:52:17 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-263-xdr-3GJLPFqI4JHd0yeVqA-1; Fri, 15 Nov 2024 06:52:16 -0500 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6A0741954B22 for ; Fri, 15 Nov 2024 11:52:15 +0000 (UTC) Received: from orkuz (unknown [10.45.226.43]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E1FB81956089 for ; Fri, 15 Nov 2024 11:52:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731671537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZfpSzKRE+8CE+/KtSjO9mUbypO13kee2jtD1e2nH+00=; b=Q8Q955pF0o9S/Qa2KUBEHDL21eTZQL0Hj4trhjV1rIffisaHTBTBzCLuDWW338YyqKaAQ5 mQCPzxke/Gl94kiQWjkWbEN89Y24DU/EPHogi/K1czGMoK4hDU9hp7QXozkkXUvyr4pL/V 3Gx5WshGpGWEN9MaZ+VbwsW5zyB3zIA= X-MC-Unique: xdr-3GJLPFqI4JHd0yeVqA-1 X-Mimecast-MFC-AGG-ID: xdr-3GJLPFqI4JHd0yeVqA From: Jiri Denemark To: devel@lists.libvirt.org Subject: [PATCH] qemu: Avoid useless tmp variable in qemuCanonicalizeMachine Date: Fri, 15 Nov 2024 12:45:28 +0100 Message-ID: <4258fa7daa9b135ccd073f91a15f1f7f108cd0ce.1731671128.git.jdenemar@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9gF18k70-oLlVqacu8k8vz-R8oUDUEBOdb4HjqQFPhU_1731671535 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: EQ34FKD3F63HMXLAIMQ6XVSHECCUX5K4 X-Message-ID-Hash: EQ34FKD3F63HMXLAIMQ6XVSHECCUX5K4 X-MailFrom: jdenemar@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1731671557770116600 Content-Type: text/plain; charset="utf-8" Signed-off-by: Jiri Denemark Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_postparse.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_postparse.c b/src/qemu/qemu_postparse.c index 11134fb030..03b5ef825a 100644 --- a/src/qemu/qemu_postparse.c +++ b/src/qemu/qemu_postparse.c @@ -947,10 +947,8 @@ qemuCanonicalizeMachine(virDomainDef *def, virQEMUCaps= *qemuCaps) return 0; =20 if (STRNEQ(canon, def->os.machine)) { - char *tmp; - tmp =3D g_strdup(canon); VIR_FREE(def->os.machine); - def->os.machine =3D tmp; + def->os.machine =3D g_strdup(canon); } =20 return 0; --=20 2.47.0