From nobody Sun Feb 8 17:22:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1557825870; cv=none; d=zoho.com; s=zohoarc; b=eCMKsHOlFPMWIs2wvQn4GO4Aa4s7Sm+8GdCgdbIksCbVTXR1AbXyUB3xZ1Hpqz9wl2deMLghVnQRkCjPfIS3Ytpx8vr2TLeblxB4osAixM5JBkFKqfsQQtPapCi1KUZMBCNGB3a/iK4MKv6lnoAMOx00wJI9slb4kDOz51354J4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1557825870; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=rCKyqCTXKoL2vE33RKAvjBPZdddr+zKkmmT0Iw4mof0=; b=f8Vn6d8VM6LOH6XdKiol4Q9puzG8d+4LswW6dkR2dmioZgUMs30KuzRoZFV+3sG8NR03HUOBL8BuMXMBFTPA93VVAL5IsUQB6S/INr/SB82rmUYCoicZVV1W1xnZeEREKbD9/pfk/R1o4siQe9ejNaycX9YBnpPz+t2SsgmP1Lk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1557825870038273.3161183568732; Tue, 14 May 2019 02:24:30 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 36CCF19DCB; Tue, 14 May 2019 09:24:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C48D19C7F; Tue, 14 May 2019 09:24:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C2A4F41F5C; Tue, 14 May 2019 09:24:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x4E9OI9S013122 for ; Tue, 14 May 2019 05:24:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7BDFD5D706; Tue, 14 May 2019 09:24:18 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 059BC5D6A6 for ; Tue, 14 May 2019 09:24:17 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Tue, 14 May 2019 11:24:09 +0200 Message-Id: <42211e65dfe958b3d433dd66337e3daa9bb5cdb0.1557825733.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/4] virstorageobj: Don't clear vols if they weren't initialized X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 14 May 2019 09:24:28 +0000 (UTC) Content-Type: text/plain; charset="utf-8" If virStoragePoolObjNew() fails to create new volume object list then virObjectUnref() is called and since refcounter is 1 then virStoragePoolObjDispose() is called which in turn calls virStoragePoolObjClearVols() which in turn dereferences obj->volumes. Signed-off-by: Michal Privoznik Reviewed-by: Erik Skultety --- src/conf/virstorageobj.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 1d6c9d1937..1d5c88f50b 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -365,8 +365,10 @@ virStoragePoolObjDispose(void *opaque) if (!obj) return; =20 - virStoragePoolObjClearVols(obj); - virObjectUnref(obj->volumes); + if (obj->volumes) { + virStoragePoolObjClearVols(obj); + virObjectUnref(obj->volumes); + } =20 virStoragePoolDefFree(obj->def); virStoragePoolDefFree(obj->newDef); --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list