From nobody Thu Apr 2 18:29:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774605559; cv=none; d=zohomail.com; s=zohoarc; b=emxSl8Up1ijTjWqhfxpppb6NdCAGUbw4WxjhV6XpVgiFwB34h6EdfzomGPYBe8ZMlWVilVe0FL/2yEaZx0UkcNjETORb0J3dqLTGyX8fc+kf31NVdX9BjnX+gIdk91HGjDSNvNJL5vwVA3k3ji5GIdqvMFGiXstCGGM8HwmvwIo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774605559; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=e1ZcnmSyKmhBYKyMea+E/+mdJS7qpk2+a5ckCdaVgP4=; b=Zjfl5xCRLuPgs/Al3kosPCbaeGI14kU4kK7pAMSW97JjfXOggCpr/sh7c2CfJX2xDvs+SH3ALD2bLUoAUsUlvUspulaysW02mlWJTBVRynoK+lGUjrBzOa3FM11T/A3iZMWebmp7M5E3BDFhS4qGcHjJhlI3E0eQVGjHkbiZL8Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774605559851588.4865256819202; Fri, 27 Mar 2026 02:59:19 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 639823F885; Fri, 27 Mar 2026 05:59:19 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 356823F364; Fri, 27 Mar 2026 05:55:57 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id BCE4C3F8B0; Fri, 27 Mar 2026 05:55:52 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 0B3654186F for ; Fri, 27 Mar 2026 05:54:57 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-217-8VD05n3eOcyz-M24Fb8C6w-1; Fri, 27 Mar 2026 05:54:55 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 81552195608D for ; Fri, 27 Mar 2026 09:54:54 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C80C130001A1 for ; Fri, 27 Mar 2026 09:54:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774605296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e1ZcnmSyKmhBYKyMea+E/+mdJS7qpk2+a5ckCdaVgP4=; b=IC4hdVx9P7yWfwgmPFDo7jTTeF3+fE2JMy0/AHuH+vQnl+CUdm0r+TgG79OqT7xRAUigQZ H8cKvKHr8+585WdcgXP5zI7v1uUeL5VPeD7B5j6xi/wssve2aUZMYVrI9gxCFuLQFWjLX5 lBdeICXMM9vSRlhghBHv7nlBBA2Rv0U= X-MC-Unique: 8VD05n3eOcyz-M24Fb8C6w-1 X-Mimecast-MFC-AGG-ID: 8VD05n3eOcyz-M24Fb8C6w_1774605294 To: devel@lists.libvirt.org Subject: [PATCH 3/6] virNetDevIPCheckIPv6Forwarding: Don't NUL terminate buffer from virFileReadAll Date: Fri, 27 Mar 2026 10:54:41 +0100 Message-ID: <420bb7b80e6f3b6b09e83004439e3c91134cb1c8.1774605192.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: u3LdWzQibHpSRiPqPpfQBano0iIuqK2mpH7Zj7mcDWk_1774605294 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KSTTLZS5BE4ARUUYRSTWMYR6RC4JCB5T X-Message-ID-Hash: KSTTLZS5BE4ARUUYRSTWMYR6RC4JCB5T X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774605560741154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The buffer is already terminated. Luckily the last character in the buffer was a newline so no information was mangled. Signed-off-by: Peter Krempa --- src/util/virnetdevip.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index 8786bb236e..c82125b706 100644 --- a/src/util/virnetdevip.c +++ b/src/util/virnetdevip.c @@ -547,10 +547,6 @@ virNetDevIPCheckIPv6Forwarding(void) return false; } - /* Dropping the last character to stop the loop */ - if (len > 0) - buf[len-1] =3D '\0'; - cur =3D buf; while (cur) { char route[33], flags[9], iface[9]; --=20 2.53.0