From nobody Sat May 4 00:01:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600692133; cv=none; d=zohomail.com; s=zohoarc; b=cP+zj2xqvvbfSaun4vbByM40bCkwLPfk3l+60BPfbKAj45+BOU5ADOTyJ6DWpPmBS4HahcJr12ukZgRjRgwKr/FhF42DxnBjUnBOK3ad5WuTK1AcwpUopxNIo8v8j8yeLuPt3cEMK8fQBklbCldLU6G4vhkEW5oohqEQHK216Bk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600692133; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=zIeEA9L7EDud5uJ3X14japz1bDm3Hm+ynY2ayVGtkaA=; b=h38bJ+1lO51pteQd3HuwsLm4nrUbyDXwWYqRZdE6ySq0u1dfkN6clr4FH/xIbmTP4VsyadhK39o+ZQA/5BrarKm9yU0gLuJEGddYPM6fXBPIvwI4i9M+HkIzpSy8rX2TQKy28WwumtAWzTbS6UMzsaNw83uKlcNjjUkbMUrg2UI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1600692133946169.85431257937535; Mon, 21 Sep 2020 05:42:13 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-65-8pSlhX8MNJS8P-hMhKZ84Q-1; Mon, 21 Sep 2020 08:42:10 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 13193802B6A; Mon, 21 Sep 2020 12:42:05 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E1EBF1B57D; Mon, 21 Sep 2020 12:42:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B03408C7D3; Mon, 21 Sep 2020 12:42:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08LCg32m016536 for ; Mon, 21 Sep 2020 08:42:03 -0400 Received: by smtp.corp.redhat.com (Postfix) id F13921A913; Mon, 21 Sep 2020 12:42:02 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.192.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id 69D21277B7 for ; Mon, 21 Sep 2020 12:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600692132; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zIeEA9L7EDud5uJ3X14japz1bDm3Hm+ynY2ayVGtkaA=; b=HdQC4gl1yz8/wSLbmmVLu62S1YxVtqAl5QbioP78JdhY2ry+iNL/iMQfmkb43N9T3jZIg0 ny7yJfgsGw5Dl0J0XP/PES/qeqMkrXBnqV4mvDi7RCjryHcBW3QBsZZuxBYRN4urh4pIZQ OocNVTOkyxvZEaM/KseU6w0lDD77r5o= X-MC-Unique: 8pSlhX8MNJS8P-hMhKZ84Q-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH] virfirewalld: fix g_variant_get call Date: Mon, 21 Sep 2020 14:41:58 +0200 Message-Id: <415b496f6f8e71da80cb3957aa03ffec66ab3943.1600692110.git.phrdina@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) We need to pass pointer to `array`. Reported-by: J=C3=A1n Tomko Signed-off-by: Pavel Hrdina Reviewed-by: J=C3=A1n Tomko Tested-by: J=C3=A1n Tomko --- src/util/virfirewalld.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfirewalld.c b/src/util/virfirewalld.c index 69c8b73da0..12448f0681 100644 --- a/src/util/virfirewalld.c +++ b/src/util/virfirewalld.c @@ -215,7 +215,7 @@ virFirewallDGetZones(char ***zones, size_t *nzones) NULL) < 0) return -1; =20 - g_variant_get(reply, "(@as)", array); + g_variant_get(reply, "(@as)", &array); *zones =3D g_variant_dup_strv(array, nzones); =20 return 0; --=20 2.26.2