From nobody Sun Feb 8 14:31:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1630783923; cv=none; d=zohomail.com; s=zohoarc; b=emL7X7LUXY9R4dnYkJFiV6LTqzYSvaDmk01rF3gC/p0qt51/o3LbVBTyfgfjMrQlLVI7wOHdCJ12iXc9rOdcMfdpyItaLgZxp1apGCJEC1FoCBTae6aN8YiaM+OWJPiad8yLPaetC8BlrK67VtQtl9m1NVdv85nTYPhyDWrt+Ac= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630783923; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vHDiSd3A7rYQCCLeaIdONPld0tDbDxWxAMHI1+Qzg+o=; b=fRFz9Fp2SgGKYntNU7N926zJmUvcOjvLRhpyTDGp516gM+imJmbgCaExJg7wSWzTMPA6y6X4DKFxsYhJS+ooyDVJJl1dxuYrVtjcDtf9zwtLrDl8OYWcMawTunF6aI8wXbXD86o1X6CA3oBpFuDnn7efKRtDxzf6B/IdR/cvlS4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 163078392362316.074082425958295; Sat, 4 Sep 2021 12:32:03 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-595-8MhaXoMoOh-jsr4jTnQVPQ-1; Sat, 04 Sep 2021 15:31:14 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E14AB5122; Sat, 4 Sep 2021 19:31:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 12F26604CC; Sat, 4 Sep 2021 19:31:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9C77444A5A; Sat, 4 Sep 2021 19:31:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 184JPuIE001938 for ; Sat, 4 Sep 2021 15:25:56 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9B8D35D740; Sat, 4 Sep 2021 19:25:56 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 257FC5D6A1 for ; Sat, 4 Sep 2021 19:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630783922; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vHDiSd3A7rYQCCLeaIdONPld0tDbDxWxAMHI1+Qzg+o=; b=AVeh4Ar1IGBeczAnCldvTLICbA3rs+CjwWVISIOHsTlaZU6fNVtSWx5CgxONm+eaKoX5R3 EGokUBR4dmbfj288jqDANN+My3OXSp2v1E4cX4OjceNmTmICOn91wSiQpffSwOR5fFBf5f V1jGQldmGZj47zPTRgKCQMLXluy/TGg= X-MC-Unique: 8MhaXoMoOh-jsr4jTnQVPQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 2/4] util: virIdentitySetCurrent: only unref the old identity on success Date: Sat, 4 Sep 2021 21:25:47 +0200 Message-Id: <411606b48a40920356f3e78747451b470456f717.1630783290.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1630783925358100001 In the unlikely case that we were unable to set the new identity, we would unref the old one even though it still could be in the thread-local storage. Fixes: c6825d88137cb8e4debdf4310e45ee23cb5698c0 Signed-off-by: J=C3=A1n Tomko --- src/util/viridentity.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/viridentity.c b/src/util/viridentity.c index e36e54ae4b..70843ecf9f 100644 --- a/src/util/viridentity.c +++ b/src/util/viridentity.c @@ -134,7 +134,7 @@ virIdentity *virIdentityGetCurrent(void) */ int virIdentitySetCurrent(virIdentity *ident) { - g_autoptr(virIdentity) old =3D NULL; + virIdentity *old =3D NULL; =20 if (virIdentityInitialize() < 0) return -1; @@ -150,6 +150,8 @@ int virIdentitySetCurrent(virIdentity *ident) return -1; } =20 + if (old) + g_object_unref(old); return 0; } =20 --=20 2.31.1