From nobody Tue Sep 22 05:47:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1783602668; cv=none; d=zohomail.com; s=zohoarc; b=d322gCoXwyDUo/uxkOP70E36bvVV7NbPVTiys7GE8CUM59WNSF9AO3qZ8hY/7Q3/qXsA48+T8GlSKllPgfHUqDO6cYMu+jAXnWOtc5a2aV5psCByuqf+xp8lzJ9Va9XANeCrHgZps7U6VmigqdCqoR5n4FcEtPdkaQP9rgCVADU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783602668; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=7Mn6SlPBAmAJo06kuN+hpTvsrVrQHpzGEiu1+wnfog0=; b=bFn7HjNIK8/xNeIXvJVALq3lcrikf5KcAULXKZsgfX6x/lVhNsTqwOMVQDtbkdTT0EQY6CetGmMZCPmUK8KVL84R3TVA91AsatwT0IvKqPuO9Uu20quAXgiEj8yNJ9G8UKLOiUX3YTPqaLzY0oPfOz3tCplGD5VqBRa+uH3ZqAk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1783602668906756.5001850496027; Thu, 9 Jul 2026 06:11:08 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id BE3C641CD0; Thu, 9 Jul 2026 09:11:07 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id D773241E4C; Thu, 9 Jul 2026 09:06:36 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id A15FE41BC0; Thu, 9 Jul 2026 09:06:08 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3854641BA5 for ; Thu, 9 Jul 2026 09:06:00 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-nL-48XaEPOWL7JOF55B8Jw-1; Thu, 09 Jul 2026 09:05:59 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 978A5195606A for ; Thu, 9 Jul 2026 13:05:58 +0000 (UTC) Received: from rsmigiel-thinkpadx1carbongen11-remote-csb.redhat.com (unknown [10.44.33.224]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A9F5336933; Thu, 9 Jul 2026 13:05:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783602360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Mn6SlPBAmAJo06kuN+hpTvsrVrQHpzGEiu1+wnfog0=; b=cxVwzdN7kloyq67zn7fFJ8Sr01Ia4X77sU9QV4u/NkDr95IsNlm6KvDD6ieq6u0ycIrxCw mqZ7h6xXKJ85mDEuumfdPsuINLtzKHI8F62YYwSOOux+R0O32sQvsoAAaZfuutsjqUI9tz BKicKUvjA45CfNEHAbFiZBfSS+ZS9vQ= X-MC-Unique: nL-48XaEPOWL7JOF55B8Jw-1 X-Mimecast-MFC-AGG-ID: nL-48XaEPOWL7JOF55B8Jw_1783602358 To: devel@lists.libvirt.org Subject: [PATCH 4/6] virsh: Add completer for '--type' option of 'domdisplay' command Date: Thu, 9 Jul 2026 15:01:00 +0200 Message-ID: <40b6c8d1b52f7097988fa05206ed74ff58a710b7.1783602062.git.rsmigiel@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: A6a9tJMG6vigJNixH9x-VZQs_K5K8IFTOcNvI7Cq_kA_1783602358 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CQUXFUZERSZ5KI3CWCZAVQJ7NE2EP64U X-Message-ID-Hash: CQUXFUZERSZ5KI3CWCZAVQJ7NE2EP64U X-MailFrom: rsmigiel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Radoslaw Smigielski X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Rados=C5=82aw_=C5=9Amigielski_via_Devel?= Reply-To: rsmigiel@redhat.com X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1783602669709158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Radoslaw Smigielski The '--type' option of 'domdisplay' command selects a particular graphical display scheme (vnc, spice, rdp, or dbus). Partially-fixes: https://gitlab.com/libvirt/libvirt/-/work_items/9 Signed-off-by: Radoslaw Smigielski --- tools/virsh-completer-domain.c | 13 +++++++++++++ tools/virsh-completer-domain.h | 5 +++++ tools/virsh-domain.c | 1 + 3 files changed, 19 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index 8bdf68ac091d..4c0ddb01d855 100644 --- a/tools/virsh-completer-domain.c +++ b/tools/virsh-completer-domain.c @@ -1132,3 +1132,16 @@ virshDomainNetTypeCompleter(vshControl *ctl G_GNUC_U= NUSED, return vshEnumComplete(VIR_DOMAIN_NET_TYPE_LAST, virDomainNetTypeToString); } + + +char ** +virshDomainDisplayTypeCompleter(vshControl *ctl G_GNUC_UNUSED, + const vshCmd *cmd G_GNUC_UNUSED, + unsigned int flags) +{ + static const char *types[] =3D {"vnc", "spice", "rdp", "dbus", NULL}; + + virCheckFlags(0, NULL); + + return vshCommaStringListComplete(NULL, types); +} diff --git a/tools/virsh-completer-domain.h b/tools/virsh-completer-domain.h index dfbc10acaaa8..3aab7bedae20 100644 --- a/tools/virsh-completer-domain.h +++ b/tools/virsh-completer-domain.h @@ -204,3 +204,8 @@ char ** virshDomainNetTypeCompleter(vshControl *ctl, const vshCmd *cmd, unsigned int flags); + +char ** +virshDomainDisplayTypeCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags); diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 79823072ad26..a546532b7dd2 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -12181,6 +12181,7 @@ static const vshCmdOptDef opts_domdisplay[] =3D { {.name =3D "type", .type =3D VSH_OT_STRING, .positional =3D true, + .completer =3D virshDomainDisplayTypeCompleter, .help =3D N_("select particular graphical display " "(e.g. \"vnc\", \"spice\", \"rdp\", \"dbus\")") }, --=20 2.54.0