From nobody Sun Feb 8 22:50:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600810379; cv=none; d=zohomail.com; s=zohoarc; b=dtTdpHFGrn9APvr3XhBxfFwnGrgr5vjIgNUio4oFu6zjVnHl4Xfm6adREJbYeRb0ApZiRukv3XHFhH8+Vr+/xmwHfL6zL2gvKYT45aD4ckZoFs545tDKNNLXnPJLQmkkYdpdnA8CTtl8qma6gYVBi164P9h5LYk5qVnq91JebM4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600810379; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WxfaJ2AFziJSVnqT13cpzr4M8vcYUb0WFEjq3MJIDCg=; b=CaSaQOmgsii56NEYPXOOhLqal63onGi6p6s5OkoHIbjIwJOOh7BqlgK3O2UU6lwXd4+14cXyVkfmZY/H8aKKUpavW8fdTRcpArtumAKwRBEz0ErmxrfUibCRQNtTQb+BAUJo2BAlw97kiFS7OBrJX3VrXnFaGvotyff4YsspeCg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1600810379862338.6703855366925; Tue, 22 Sep 2020 14:32:59 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-vT9Evp4OPby7Vx1-BlBRbQ-1; Tue, 22 Sep 2020 17:32:56 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 50A9081CAFB; Tue, 22 Sep 2020 21:32:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 288DB1A923; Tue, 22 Sep 2020 21:32:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E085C1826D2E; Tue, 22 Sep 2020 21:32:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08MLWn0u022731 for ; Tue, 22 Sep 2020 17:32:49 -0400 Received: by smtp.corp.redhat.com (Postfix) id 929DF1001901; Tue, 22 Sep 2020 21:32:49 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 18A61100164C for ; Tue, 22 Sep 2020 21:32:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600810378; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=WxfaJ2AFziJSVnqT13cpzr4M8vcYUb0WFEjq3MJIDCg=; b=Yq7jDKQ5Tk+64Uka0ikhFMejEhBqA0zTAh3jqRq8oVQdI9wOd0rD+OSYuGLjCpyy99Vz0l pvb/2U4o+eV8jV7Y9wyhRPqKqMVL22gXYUsMbZsXHVHwrzMoQjLndYDv14FAKgtdK4NDlM CeUBYT4SNnn0WA1Q0NmQTI/bZMIVH88= X-MC-Unique: vT9Evp4OPby7Vx1-BlBRbQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 4/5] virsh: do not return bool in virshNetworkPortUUIDCompleter Date: Tue, 22 Sep 2020 23:32:32 +0200 Message-Id: <40ac45c2dd7532a17039719f84d142821262a716.1600810297.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) portability: Returning an integer in a function with pointer return type is not portable. [CastIntegerToAddressAtReturn] Signed-off-by: J=C3=A1n Tomko --- tools/virsh-completer-network.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-completer-network.c b/tools/virsh-completer-networ= k.c index a63d657477..73f7115ab2 100644 --- a/tools/virsh-completer-network.c +++ b/tools/virsh-completer-network.c @@ -103,7 +103,7 @@ virshNetworkPortUUIDCompleter(vshControl *ctl, return NULL; =20 if (!(net =3D virshCommandOptNetwork(ctl, cmd, NULL))) - return false; + return NULL; =20 if ((nports =3D virNetworkListAllPorts(net, &ports, flags)) < 0) return NULL; --=20 2.26.2