From nobody Mon Feb 9 00:56:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1646386382; cv=none; d=zohomail.com; s=zohoarc; b=JXbACB9rjU7lhVXPFmOaOU30yUSnJJNRQD7eGw9/WF1ND9Qi/3rJPje9vrcMuGkGpslwm5dPHvlOOLgQZFlVPcEEOChATrQMhROOIk1Ryp1gN3lk2X7dniO/0H5qJvTTT9BhP/FwKvhEtHCjfQdpNhc5UpyfWU3pPrBBiomNBRk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646386382; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=W/jsXbZNtnHC8AxkTDbfK52v1OmTGyqH2MMFDbawy+o=; b=h6NVavYlJnAok2bpJ+stOb/vXQ/SBTmONB4RwjBN2FuoY+5P4xhwaWa1IG84i/91lOI/Th1GJ/2szSeirIu50/4446ljhC6Bz9za+g4lOdxfGl/qDyzsckfbnG2BSF0+bkjFRADLYqAxPyABf3N73d2V6AwN6GOVy/7jk78jprI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1646386382534135.11563691938557; Fri, 4 Mar 2022 01:33:02 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-135-Gh2xDw8RM6KUkEyf0BeaJw-1; Fri, 04 Mar 2022 04:32:22 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AD22A824FA8; Fri, 4 Mar 2022 09:32:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 74D0467E7A; Fri, 4 Mar 2022 09:32:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7445B1809CB2; Fri, 4 Mar 2022 09:32:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 2249WAGa017747 for ; Fri, 4 Mar 2022 04:32:10 -0500 Received: by smtp.corp.redhat.com (Postfix) id A0A6E6E20F; Fri, 4 Mar 2022 09:32:10 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2255066E34 for ; Fri, 4 Mar 2022 09:32:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646386381; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=W/jsXbZNtnHC8AxkTDbfK52v1OmTGyqH2MMFDbawy+o=; b=JTlw3OReed7joEZzxO71PN43kA/f5AfR65caYCwZ8tRgYN+hCLsxnRrq2P9xxkrpMx9z6r D2DDKbK+ugET/CGW4xQs3glE1MLKsqh3RlgaS8+1KvqVp4ilDatahLXdVyLHenj7CAFFfM ey297Semr2/dCKbhzIyDedfhWWwBzLY= X-MC-Unique: Gh2xDw8RM6KUkEyf0BeaJw-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/4] vircgroupmock: Make global variables static Date: Fri, 4 Mar 2022 10:31:59 +0100 Message-Id: <406be86e724267e2c09285024a2a03c7351352aa.1646386097.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1646386383201100001 Content-Type: text/plain; charset="utf-8" Apparently clang was fixed as it no longer considers having global variables static a problem. Make the variables static to be sure they aren't used outside of the source file. This effectively reverts v1.0.6-rc1~198 which started the trend. Signed-off-by: Michal Privoznik --- tests/vircgroupmock.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/tests/vircgroupmock.c b/tests/vircgroupmock.c index cbf5269df6..a213c8e686 100644 --- a/tests/vircgroupmock.c +++ b/tests/vircgroupmock.c @@ -36,14 +36,10 @@ static FILE *(*real_fopen)(const char *path, const char= *mode); static int (*real_access)(const char *path, int mode); static int (*real_mkdir)(const char *path, mode_t mode); =20 -/* Don't make static, since it causes problems with clang - * when passed as an arg to asprintf() - * vircgroupmock.c:462:22: error: static variable 'fakesysfsdir' is used i= n an inline function with external linkage [-Werror,-Wstatic-in-inline] - */ -char *fakerootdir; -char *fakesysfscgroupdir; -const char *fakedevicedir0 =3D FAKEDEVDIR0; -const char *fakedevicedir1 =3D FAKEDEVDIR1; +static char *fakerootdir; +static char *fakesysfscgroupdir; +static const char *fakedevicedir0 =3D FAKEDEVDIR0; +static const char *fakedevicedir1 =3D FAKEDEVDIR1; =20 =20 # define SYSFS_CGROUP_PREFIX "/not/really/sys/fs/cgroup" --=20 2.34.1