From nobody Mon Apr 29 19:23:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1629382572; cv=none; d=zohomail.com; s=zohoarc; b=Pku5T02LwcQD7uXn48XKsYncE9cgOJOXraDVxhAZxurCpb6oOKGq8kAqRZBffj+HH6uPnhvvPuI0MgRO5PdA0bWLh+0l2Vjd6MnDqTyK9fT6kC5z8mzcelSCpcUm4w7X+uo8Az4QKKcAwyN2dZvmpV1BMI2cxtVJICPFcSVEgf0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629382572; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=vKhpxaZr9e0xAlDNJvw1beJQggkqWOkVBzN4tS2aCxA=; b=B6Svk48GmBA1GvuXGEVjOGLWXmoJH/xByG1FTefxgYyMrN9isgmZV8Tw9CLHaAchI22bf4UBOKQw591v8szCxf/SSuaaHgdwtTUtU9t7aI32eccgwnQoFiNROaPJMcMBpKrN737bHY3tOiGOiuI2jk6FLai2eVvWE9YliC2w2sk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 162938257222917.998773035960994; Thu, 19 Aug 2021 07:16:12 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-353-zb061EPOMbeG9mqE3_O7Kw-1; Thu, 19 Aug 2021 10:16:09 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1AC3760FC; Thu, 19 Aug 2021 14:16:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B487F18B42; Thu, 19 Aug 2021 14:16:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 621FC181A1CD; Thu, 19 Aug 2021 14:16:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 17JEF6Pf015888 for ; Thu, 19 Aug 2021 10:15:06 -0400 Received: by smtp.corp.redhat.com (Postfix) id B330D10013C1; Thu, 19 Aug 2021 14:15:06 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 15552100EBAD; Thu, 19 Aug 2021 14:15:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629382571; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vKhpxaZr9e0xAlDNJvw1beJQggkqWOkVBzN4tS2aCxA=; b=bdhjr3HxJHSRPyMuufq85UEKJw33a0vtQ/LB1NEuUoEM214zA6o8Ca4ePXjsU5jUkL9Stn 0n/a1UrjE0Jimoi0NfulYfbAI4cq/eUEX10eHNVE0C1lXIeUZBLEGin3W/AqCZh1ouDrJU OvdGkEZaJeuDTu23XpSaSQNPpB+9C78= X-MC-Unique: zb061EPOMbeG9mqE3_O7Kw-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH] ch: monitor: unref mon->vm before vm Date: Thu, 19 Aug 2021 16:15:00 +0200 Message-Id: <403d6ae81dc58142734451edb6caf50a998a53df.1629382486.git.jtomko@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: william.douglas@intel.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1629382573188100001 Do not access 'mon' after unref'ing it. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Michal Privoznik --- src/ch/ch_monitor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c index 1648d05017..0f8752d1ed 100644 --- a/src/ch/ch_monitor.c +++ b/src/ch/ch_monitor.c @@ -543,9 +543,8 @@ void virCHMonitorClose(virCHMonitor *mon) g_free(mon->socketpath); } =20 + virObjectUnref(mon->vm); virObjectUnref(mon); - if (mon->vm) - virObjectUnref(mon->vm); } =20 static int --=20 2.31.1