From nobody Tue Nov 26 11:43:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1574696270; cv=none; d=zohomail.com; s=zohoarc; b=VBWTO+PGymlbNPPszuewcrdG2kzXO+5ECrNyujlhXe9yDk+bOlWIm+mrLfXs7LLH5GhbLDclBeceXK+RNeqoObzduWlP7I+dpB6o47ZMIytZbGCsriE2A1TGLTOhX04FFQo6HLVQjuJ5Yi7CAaTeWXQU8vEykMTElWxrZnTR/uU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1574696270; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=5cttiHIe8wf/lM5dwOfhlPNlDf18kYyfwBFktHrOX8s=; b=UJVjpbM9Z7g/dpD/3Zaw3XuDYnUaFhl9ImpDkPvMxHG5eZ15VMTKRr8oh92Sg3BdxxBMKChwX3DuEta5f+TbCsl06ZWWsvaZus25bhjhPF6WUOASb+iZtia8awpJtxyxBRiEuuOzpCZqm4UbnjNJKICkP3s014rG1XXuI/6D4w4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1574696270087763.4488913218539; Mon, 25 Nov 2019 07:37:50 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-FqNWOID1Nl6r9wvnqixjjQ-1; Mon, 25 Nov 2019 10:37:46 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0D9398D4F4F; Mon, 25 Nov 2019 15:37:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A23619C69; Mon, 25 Nov 2019 15:37:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6BC5C4BB65; Mon, 25 Nov 2019 15:37:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xAPFbbSO023398 for ; Mon, 25 Nov 2019 10:37:37 -0500 Received: by smtp.corp.redhat.com (Postfix) id 7C05F19C6A; Mon, 25 Nov 2019 15:37:37 +0000 (UTC) Received: from angien.redhat.com (unknown [10.43.2.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0453019C69 for ; Mon, 25 Nov 2019 15:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574696269; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=5cttiHIe8wf/lM5dwOfhlPNlDf18kYyfwBFktHrOX8s=; b=Xv0O4wTxjw1mQm814bDD2bM+e9sf2/31jQY2wDbWut6Wymbe1ppHHbpglR3QV03cgihPoV SDp/6+hPI1tbxv5oyKGzq+H2FgAF1NipJZ4Cn2c7ZzMwz0Ewr9y+iGH2J6jO2T9upLiZdx VEzlHcDuDkuMmsaKzxrJ0qWwcD6D5BM= From: Peter Krempa To: libvir-list@redhat.com Date: Mon, 25 Nov 2019 16:37:36 +0100 Message-Id: <3fc1cc3c31441b75ca5bbc43fa34d6ef4738b3b9.1574696256.git.pkrempa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] check-symfile: Use pythonesque string formatting instead of perl X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: FqNWOID1Nl6r9wvnqixjjQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Commit d30a1ad0443 translated the symbol file checker from perl to python by doing a literal translation in most cases. Unfortunately one string formatting operation was not really translated into python leaving users with non-helpful error: 'Symbol $1 is listed twice' Signed-off-by: Peter Krempa Reviewed-by: Erik Skultety Reviewed-by: Michal Privoznik --- scripts/check-symfile.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/check-symfile.py b/scripts/check-symfile.py index 0c02591991..34396b8623 100755 --- a/scripts/check-symfile.py +++ b/scripts/check-symfile.py @@ -52,7 +52,7 @@ with open(symfile, "r") as fh: line =3D line.strip(";") if line in wantsyms: - print("Symbol $1 is listed twice", file=3Dsys.stderr) + print("Symbol %s is listed twice" % line ,file=3Dsys.stderr) ret =3D 1 else: wantsyms[line] =3D True --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list