From nobody Tue Sep 9 03:11:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1749732852; cv=none; d=zohomail.com; s=zohoarc; b=A/uT1D6Etcld7gIN2oRGosuw5MPpIQ5Sk17bxVxFWnv6rPTKbRzQbXQgvwXE2U2P86CQiRSkT+qsWWgazb7wK1uaf1tnmxPk6QuRRjijiNW4DKYjyMXEZGuZRppFx6EOaGXt8l7t2oE2BJdhgHEvnaMzA7p/ftRz9ILxkRFuCiQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749732852; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=2i7Vndfduh806utcCGA5wBEXCS3Wf/oo9nnIIZOGIw0=; b=UCJaXgl3xNt5BlrpoWDIgHbExMsJvl39qDc/XcJ9StnLnlJI2uImZcoDOLEWUl/+KK0dPjqJ+2coPL9m1eh765aHp57t8Odko1Kp8GnYhQlQtXHI0gb1yM4u9/Kg2OsK2JOfPVWOF5gkpLVrbdw+b3KsTHk2a/HlvLNbHrMPNRo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1749732852506529.6292449241279; Thu, 12 Jun 2025 05:54:12 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 69D801431; Thu, 12 Jun 2025 08:54:11 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id D85D31401; Thu, 12 Jun 2025 08:49:33 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 6DAD8E3D; Thu, 12 Jun 2025 08:49:26 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 86AB7D63 for ; Thu, 12 Jun 2025 08:49:08 -0400 (EDT) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-CK2YIxYbNIqihXD8OB4F8A-1; Thu, 12 Jun 2025 08:49:06 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EA42319560AA for ; Thu, 12 Jun 2025 12:49:05 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4094B19560A3 for ; Thu, 12 Jun 2025 12:49:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749732548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yfgGEM0fhbAfW9w49tGDgQxK8PUb9p2b/E/UdS/1Xq8=; b=HAJYdc3D1JR0qa7RNY2v+L/FdOKbjIFYQJwe+IBN1ZLKD8shmO+F8E1l2cj24kRxKCMCIq IJvs0HudO3VvXbbGrr/CLaXBrHQPtFF/yBxIl7Aqc7l/9noJ1EzE2HNMytmvsopbx6fzS2 mdLbjIcL/GGrlWAWIGbZ8YYV3lMEYG8= X-MC-Unique: CK2YIxYbNIqihXD8OB4F8A-1 X-Mimecast-MFC-AGG-ID: CK2YIxYbNIqihXD8OB4F8A_1749732546 To: devel@lists.libvirt.org Subject: [PATCH 13/15] virt-aa-helper: Check retval of vah_add_file() Date: Thu, 12 Jun 2025 14:48:45 +0200 Message-ID: <3f0dfb3d3bf221d0f479549cad686e7ed621c390.1749732372.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: i3uNwYjIU6dytguG1CtIALUZy6fUeFu1Q3ARTV90aS4_1749732546 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: UJJS2HSLCVFNMQRMISRI6JR23ALVFIRP X-Message-ID-Hash: UJJS2HSLCVFNMQRMISRI6JR23ALVFIRP X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749732854248116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik Inside of get_files() there are two cases where vah_add_file() is not checked for its retval. This is possibly dangerous, because vah_add_file() might fail. Fix those places by introducing checks for the retval. Signed-off-by: Michal Privoznik --- src/security/virt-aa-helper.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 2ea4b47fa5..7748a0d19b 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -1022,15 +1022,17 @@ get_files(vahControl * ctl) const char *rendernode =3D virDomainGraphicsGetRenderNode(graphics= ); =20 if (rendernode) { - vah_add_file(&buf, rendernode, "rw"); + if (vah_add_file(&buf, rendernode, "rw") !=3D 0) + goto cleanup; needsgl =3D true; } else { if (virDomainGraphicsNeedsAutoRenderNode(graphics)) { g_autofree char *defaultRenderNode =3D virHostGetDRMRender= Node(); needsgl =3D true; =20 - if (defaultRenderNode) { - vah_add_file(&buf, defaultRenderNode, "rw"); + if (defaultRenderNode && + vah_add_file(&buf, defaultRenderNode, "rw") !=3D 0) { + goto cleanup; } } } --=20 2.49.0