From nobody Tue Feb 10 00:59:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1632439875; cv=none; d=zohomail.com; s=zohoarc; b=ilvFho/qZ+4NR4AqDtfJs/i9svaRs8I3u7mzXlpFoaxHRJPjQ1KAXZ3dQszTeBIcpuKANxR+nJUKi0Jc+arSqS4WVnaQhcmNg7uDmCMtbpREs2HnYY/CzkOCzTprLVW7916L+vMzPtOYUOhzp+Sv53fAup3m6eYxiAnf75URrBA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632439875; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9fCTl8BSUiQSmOmyQPGMNcpWhbe5Szl4NYo1+ioy2BM=; b=PnoOSBP8a7Di49MtYn8l48MWWY1IpRqeucqQrKMyjfGbhAq499EQJLWrP7bIAL08EkCS9WodvybFQN+USZyaDmXWGmiFo3/ZTpbIjEx9Cl0f5cIBNPZxto/eTMs+nq+wFwrJ0XzPkfbVg+KEjxVCmRCS81iAOt4g7iLNt5O/VKY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1632439875193147.28177251084696; Thu, 23 Sep 2021 16:31:15 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-347-8BHWcf0hM0Orlk2ksRuXyw-1; Thu, 23 Sep 2021 19:31:12 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7C301801B3D; Thu, 23 Sep 2021 23:31:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B7281007606; Thu, 23 Sep 2021 23:31:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2500E4EA30; Thu, 23 Sep 2021 23:31:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 18NNV6Cu011119 for ; Thu, 23 Sep 2021 19:31:06 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5BD11171FF; Thu, 23 Sep 2021 23:31:06 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.40.192.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3605F7621B for ; Thu, 23 Sep 2021 23:31:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632439874; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9fCTl8BSUiQSmOmyQPGMNcpWhbe5Szl4NYo1+ioy2BM=; b=CaV8o4WssIp0O4IPLpIMO1EBrdbXEco41gW8NY2BmFp/vSiEelt8cHRqfueXdDKj3s4hHU e8quy8etfs1p/U6Swk9smMwV1RtZxzHVgQPFaA4B0tdAyRQe9VqzYwV6PVRPadS+GOjTvI +EkoAQr3bH3oy2zc4eIAfOUrXRJlmpo= X-MC-Unique: 8BHWcf0hM0Orlk2ksRuXyw-1 From: Kristina Hanicova To: libvir-list@redhat.com Subject: [PATCH v2 2/2] virsh: domain: remove unnecessary variable and label in cmdMigrateSetMaxDowntime() Date: Fri, 24 Sep 2021 01:30:49 +0200 Message-Id: <3f0daaf8008e30a7225a5f5aa5945376f611615d.1632439675.git.khanicov@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1632439876639100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Kristina Hanicova --- tools/virsh-domain.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 2730acfba5..cfa0016296 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -11006,25 +11006,19 @@ cmdMigrateSetMaxDowntime(vshControl *ctl, const v= shCmd *cmd) { g_autoptr(virshDomain) dom =3D NULL; unsigned long long downtime =3D 0; - bool ret =3D false; =20 if (!(dom =3D virshCommandOptDomain(ctl, cmd, NULL))) return false; =20 if (vshCommandOptULongLong(ctl, cmd, "downtime", &downtime) < 0) - goto done; + return false; + if (downtime < 1) { vshError(ctl, "%s", _("migrate: Invalid downtime")); - goto done; + return false; } =20 - if (virDomainMigrateSetMaxDowntime(dom, downtime, 0) < 0) - goto done; - - ret =3D true; - - done: - return ret; + return virDomainMigrateSetMaxDowntime(dom, downtime, 0) =3D=3D 0; } =20 =20 --=20 2.31.1