From nobody Sun Feb 8 17:04:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612285052; cv=none; d=zohomail.com; s=zohoarc; b=j+DrSAvOYe5N/2Z5e8jPYsCb1m4vAt7V6XT/inG2M8UJBE+fi5WGqwLrFuzA67TGyxhhc9ogQx09NqOlejQkIvmE1B6BaL1K2/D9iGZv3S7F4W6zAf5qawBXzJjRHFf0IrKJcwRLkN37VQdB0yrzdK4rT8LsYpZzPfTwmkvxQ/U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612285052; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ete/hxZp+xSXC3Jd9oBr+/AZkOBz91yXVyFxKLQIkc8=; b=BRY2RmS273BpAHEaOZUgtjO2Wgaxv2xmf+KFVg2VZXRUQbtJc1o7WS8YVYZJW/VLOGgkCi7ewlVxBIUFP2nXq4nnhcvBRbusUyahmJpHObOd36piO+RDEYH4/SnUnB1STctLS6BVltQLHdWtmlOZF2eWCDZMFlOYJqM9e2sX5Sk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 161228505285584.58725070232106; Tue, 2 Feb 2021 08:57:32 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-458-das976NaPn2UZkDB9dhs4g-1; Tue, 02 Feb 2021 11:57:28 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0F45C803620; Tue, 2 Feb 2021 16:57:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D931E7EA92; Tue, 2 Feb 2021 16:57:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9F6AD180881C; Tue, 2 Feb 2021 16:57:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 112GvLDt015390 for ; Tue, 2 Feb 2021 11:57:21 -0500 Received: by smtp.corp.redhat.com (Postfix) id D06416EF41; Tue, 2 Feb 2021 16:57:21 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC1286E510 for ; Tue, 2 Feb 2021 16:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612285051; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Ete/hxZp+xSXC3Jd9oBr+/AZkOBz91yXVyFxKLQIkc8=; b=e1lkGd0xKkre64Ol6JTQdkF8JLv1Fz9vRnnFK1e0tPlP5L1EUEA87tYUGkFgtrA+hKHF42 HYvaTY48MmR05zcbQ4fNi9YArIxSKcfHKB2jBBzT23SuOtHP3OLMgHiOujmuv59JckkwDJ I9WxuWWG/NmN+24xK86I2VD6EAClgRw= X-MC-Unique: das976NaPn2UZkDB9dhs4g-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH v2 20/27] libxlMakeNetworkDiskSrc: Use virSecureEraseString instead of VIR_AUTODISPOSE_STR Date: Tue, 2 Feb 2021 17:55:57 +0100 Message-Id: <3e9ccb40a8c95ffd9592cc04abcfca5987cb47fa.1612284661.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Krempa Reviewed-by: Daniel P. Berrang=C3=A9 --- src/libxl/libxl_conf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 694192e1c3..de0fd66842 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -999,7 +999,7 @@ static int libxlMakeNetworkDiskSrc(virStorageSourcePtr src, char **srcstr) { virConnectPtr conn =3D NULL; - VIR_AUTODISPOSE_STR base64secret =3D NULL; + g_autofree char *base64secret =3D NULL; char *username =3D NULL; int ret =3D -1; @@ -1022,7 +1022,10 @@ libxlMakeNetworkDiskSrc(virStorageSourcePtr src, cha= r **srcstr) virSecureErase(secret, secretlen); } - if (!(*srcstr =3D libxlMakeNetworkDiskSrcStr(src, username, base64secr= et))) + *srcstr =3D libxlMakeNetworkDiskSrcStr(src, username, base64secret); + virSecureEraseString(base64secret); + + if (!*srcstr) goto cleanup; ret =3D 0; --=20 2.29.2