From nobody Mon Feb 9 04:30:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1637253304; cv=none; d=zohomail.com; s=zohoarc; b=kIm9X7X8crUkYPbCu/ed/8o46R0uVLAfTeBWAyZ6NHsga5LBF3Y/w/TKnwFuEv1OvFg2Jv9UE4vxKEmKDmBqbyoDyXau0MIy4TFVyoudOLpp/dBOI6acBEAYnLVLnVU4NMsfLCyH9ORzYkwlzvWv2skVrr0N6BWEleiaKeWz1xc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637253304; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hUeG5pPoCy47wWiN1U4d0vN7dWXhFZKmPv2qclRQL5U=; b=ackdL2WzEzRklMy+1q8pLscmwyCOsBFpeVUJod8l7OusKxjkdgL1rAEsXKtwC/rs7npH/yyQKHJlZK9xtHuhlw5zRWmTxAcxYeTLzZT7dj0TZBHg45jNE6z/boACNWKkkltaJPx8TH8epBRykaQPHvTKsjqJaud+KZ/hKHp8pZc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1637253304322876.7388377463037; Thu, 18 Nov 2021 08:35:04 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-583-a8YJewWiMyyaFNjt4J8ZAA-1; Thu, 18 Nov 2021 11:34:23 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 41E8C8799F3; Thu, 18 Nov 2021 16:34:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E6C3ADF9; Thu, 18 Nov 2021 16:34:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D7BBA4EA3C; Thu, 18 Nov 2021 16:34:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AIGXlmd028021 for ; Thu, 18 Nov 2021 11:33:47 -0500 Received: by smtp.corp.redhat.com (Postfix) id 835EF608BA; Thu, 18 Nov 2021 16:33:47 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id CCB801B5C0 for ; Thu, 18 Nov 2021 16:33:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637253303; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=hUeG5pPoCy47wWiN1U4d0vN7dWXhFZKmPv2qclRQL5U=; b=AGXJV7qIAckxZ6gPFkAXPPSk+3yflqHY9zzvpwWU0v2IARQe5XmV3O1pquyp4+vyRFdi6S rRwZbWo0OTTpbCveFL516CtZw02TowmRCseRINE7qf2beu/2SftkYvPzrzTanWWsUJgE3r i11d4TH1rjtknL+96j2XLFlXbA3E6FQ= X-MC-Unique: a8YJewWiMyyaFNjt4J8ZAA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 01/16] qemuBuildCommandLine: Properly check return value of qemuBuildShmemCommandLine Date: Thu, 18 Nov 2021 17:33:26 +0100 Message-Id: <3e5f9a7b9e1ca1a676140b23f60a6538d703b9ff.1637253107.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1637253305676100001 Content-Type: text/plain; charset="utf-8" Use the customary '< 0' check for return value. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 713304dd22..24dd00af9b 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -10882,7 +10882,7 @@ qemuBuildCommandLine(virQEMUDriver *driver, for (i =3D 0; i < def->nshmems; i++) { if (qemuBuildShmemCommandLine(logManager, secManager, cmd, cfg, def, def->shmems[i], qemuCaps, - chardevStdioLogd)) + chardevStdioLogd) < 0) return NULL; } --=20 2.31.1