From nobody Tue Oct 28 16:42:06 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1760966651; cv=none; d=zohomail.com; s=zohoarc; b=FrroBj8BDcLYvQU2mlcAEnACt6pTrfRMyAUPwaNgGMOQfNBIsP3MmDAm2oEL+lB6Wo3FRTl3lVlXlZZo6JDjtjV9AEmEXBLr6LpnJG9lC7ZonHEpR8P/4/7MJ5jYBKOpU/33OPV4xAAcad55PqWJkmQrAyVMfYtW2ZZ+dDe9zyA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760966651; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=fKbq/C4bEMj+AOP/qiGJh0U9zRh5pKSfzzr9y0jVq+U=; b=ByYsojOavUQceqN5ORmNYE7sECJDzL4A2u8GpVSIHVhAfGD4rR4ZqiGc+7OyY1s02M0W0KDpE/mRwfmnud76gdDSjDhleIFjfr6gJRyciJrx6Q4Qq1FIwkchZrXORvsyiTTy1YVpm3I80n9CmN6cCOJAETXRL73b6UMNyDYdnD4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1760966651274184.99106096261107; Mon, 20 Oct 2025 06:24:11 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 52EAF41834; Mon, 20 Oct 2025 09:24:10 -0400 (EDT) Received: from [172.19.199.20] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 5619E41C2B; Mon, 20 Oct 2025 09:23:04 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 99F5841892; Mon, 20 Oct 2025 09:21:27 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A994C3FCF5 for ; Mon, 20 Oct 2025 09:21:26 -0400 (EDT) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-340-jVv0NytnM4uvpdExwgUQLQ-1; Mon, 20 Oct 2025 09:21:24 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F0B701954190 for ; Mon, 20 Oct 2025 13:21:23 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.15]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3ED20180057C for ; Mon, 20 Oct 2025 13:21:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760966486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fKbq/C4bEMj+AOP/qiGJh0U9zRh5pKSfzzr9y0jVq+U=; b=LoKwv3rGf7jXCZCjJ7BgFRXAml8QaxSaatotZG8A/4LDLXLwZvPFuQkIPuaoDK1n9mg8YS O7GVY9+Rptij/c9vM3b6b6bGWnN6l2AskQmWpehHwPK3BEXwcwUfjgqKrrxTxV2FSaob6j jomePeIzAZGxkElX4E9w/aKRWZ0/C2E= X-MC-Unique: jVv0NytnM4uvpdExwgUQLQ-1 X-Mimecast-MFC-AGG-ID: jVv0NytnM4uvpdExwgUQLQ_1760966484 To: devel@lists.libvirt.org Subject: [PATCH 2/3] virNetDevVlanParse: Use g_autofree for temporary variables Date: Mon, 20 Oct 2025 15:21:18 +0200 Message-ID: <3e395085ca7b342a4025d0acf9a27fdccd6bdd15.1760966455.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5cOUG-mrlq6hIqZS2fXPRTfgiI100PNfYkhoZbonRKU_1760966484 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 22343TUEQLLIUDCXODTWJXS3GKPBWYMH X-Message-ID-Hash: 22343TUEQLLIUDCXODTWJXS3GKPBWYMH X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1760966656461154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Automatically free the variables to prevent leaks when returning from middle of the function. Fixes: 1de6fd5edb5 Closes: https://gitlab.com/libvirt/libvirt/-/issues/824 Signed-off-by: Peter Krempa --- src/conf/netdev_vlan_conf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/conf/netdev_vlan_conf.c b/src/conf/netdev_vlan_conf.c index b98c4d92cf..012a28034e 100644 --- a/src/conf/netdev_vlan_conf.c +++ b/src/conf/netdev_vlan_conf.c @@ -34,8 +34,8 @@ virNetDevVlanParse(xmlNodePtr node, xmlXPathContextPtr ct= xt, virNetDevVlan *def) { int ret =3D -1; VIR_XPATH_NODE_AUTORESTORE(ctxt) - char *trunk =3D NULL; - xmlNodePtr *tagNodes =3D NULL; + g_autofree char *trunk =3D NULL; + g_autofree xmlNodePtr *tagNodes =3D NULL; int nTags; size_t i; @@ -120,8 +120,6 @@ virNetDevVlanParse(xmlNodePtr node, xmlXPathContextPtr = ctxt, virNetDevVlan *def) ret =3D 0; cleanup: - VIR_FREE(tagNodes); - VIR_FREE(trunk); return ret; } --=20 2.51.0