From nobody Fri May 17 07:47:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618817677; cv=none; d=zohomail.com; s=zohoarc; b=kTSJaLGQmvmbdBcuGbYlUJRWFNcxaoD2RwDrRVAt8TpGCLVdwchisusfW7eNC97mxRlv+7i1yjEIc12gb/znbjrqMr6YXT86WNV3X4osH21P2zCPUDJ+9/XOvA7GXxvyOa5DOXRKu9FphU0KnfD0rSM19J7Bwx3Z9MQYi3+mslc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618817677; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=uwCqIxFc+HOam8wsQR+1YXAi7ckxfv3gqCB3NMUmqj4=; b=CMWCvCtW3AJXH89kKsMbST5J35v/E/hHjGEFEFj4NbGiSMDiyjTZ/HW23GH4dZxRCdGxH1TOMR09lh9keMWuJmFdZW50o15iOI1OaFHorWItYpFd5NeqJXnvWG2YeOb+3qdt1vb9wyrClKJsUhnmDOOt6dIXVMHQy/hlsjn8Nes= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1618817677851272.5076048652245; Mon, 19 Apr 2021 00:34:37 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-274-NuYV4R_PMxCraA3FueGx1Q-1; Mon, 19 Apr 2021 03:34:34 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1419881744F; Mon, 19 Apr 2021 07:34:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE2645D72E; Mon, 19 Apr 2021 07:34:27 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 419E944A58; Mon, 19 Apr 2021 07:34:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13J7YLFl017987 for ; Mon, 19 Apr 2021 03:34:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id BC226100F49F; Mon, 19 Apr 2021 07:34:21 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F4D3107D5C6 for ; Mon, 19 Apr 2021 07:34:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618817676; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=uwCqIxFc+HOam8wsQR+1YXAi7ckxfv3gqCB3NMUmqj4=; b=c2ln0JTormD5e+w/a2wF0J6xXlhZG1pUI9KvBhj6D4P6QDi2X42n9H9fwwu8VWJprFewi8 vIAMlsECwprRfr6OO0OhK6WE909BhaQFiVVTqZ21/A7f+UuClCyBsImjGpcT4UFLTPT5PD lRNr+H9KTUOsyCQLmw+JQUZbElHScTc= X-MC-Unique: NuYV4R_PMxCraA3FueGx1Q-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] lxc: Format --handshakefd for controller cmd fully Date: Mon, 19 Apr 2021 09:34:16 +0200 Message-Id: <3e2381c43cd57f501969188aab26e0f62d410379.1618817651.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The command line argument is called --hanshakefd (check out lxc_controller.c:main()). But the command line builder puts only --handshake. This works, because there is no other argument sharing the prefix. Signed-off-by: Michal Privoznik Reviewed-by: Pavel Hrdina --- src/lxc/lxc_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index b2a7f105a9..ac635efe7a 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -1002,7 +1002,7 @@ virLXCProcessBuildControllerCmd(virLXCDriver *driver, virCommandAddArgPair(cmd, "--security", virSecurityManagerGetModel(driver->securityManage= r)); =20 - virCommandAddArg(cmd, "--handshake"); + virCommandAddArg(cmd, "--handshakefd"); virCommandAddArgFormat(cmd, "%d", handshakefd); =20 for (i =3D 0; veths && veths[i]; i++) --=20 2.26.3