From nobody Wed Jun 24 21:45:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1782125822; cv=none; d=zohomail.com; s=zohoarc; b=l2pSAJJI9gMc8IY1Pg5+syBEtuCE0JGM2fKdrMfDsXBpTto4kmMMlDRp7VmmBaCsbKvz5ghKIXjBEIWVHeTPnDBEIlF7tOpj+7zQdXNt1REv19MqidUHDLKnoRzCDRA+5PAU/nYmRwWCm5jBBd7fQL0VlWKP/wo//31Q4Km8Qok= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782125822; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=pFeNUOyqWI2XK/JYnx7EGeNSbRJceDj19V6jZPkRrUU=; b=On3XVvODAGv803kenVmuWGs4C5HZlJfe4gOAdOnq5MY4Ux8MUOean/lkgfQODR9d7Kl2IV++mOxnZhgQRnbYB94BDjkVzlKrXDiR7dCjiw9h+5IKLymsMLgTn2AooB3nGyc6Vjcgnl7wdVMmsENtgH9IGivRXeEuXc7t3P4BPOQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1782125822547995.9402445172891; Mon, 22 Jun 2026 03:57:02 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 0C91241C30; Mon, 22 Jun 2026 06:57:00 -0400 (EDT) Received: from [172.19.199.7] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id AE1AD41D4B; Mon, 22 Jun 2026 06:56:16 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 3966841BD8; Mon, 22 Jun 2026 06:56:07 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id F1E3141B57 for ; Mon, 22 Jun 2026 06:56:05 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155-B9KXQamoPcazm_7_GuCEoQ-1; Mon, 22 Jun 2026 06:56:04 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2A7C41956045 for ; Mon, 22 Jun 2026 10:56:03 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7973F195394E for ; Mon, 22 Jun 2026 10:56:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782125765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pFeNUOyqWI2XK/JYnx7EGeNSbRJceDj19V6jZPkRrUU=; b=VTf76kwXVifDvFvNP28ysoXQ83WNbaAyaDo6X0PKAEw9Hin6FTeciHPDwxWbbjGnaEcAAL FQmVMIU72nZ3OmXrpq6NDJJBkhU3hgNBXVdf26fZlXup65JhgU//SaK53Q3tPKq//2nF1R lIfn+UzruSSetccjze3wW6hZZogsNSw= X-MC-Unique: B9KXQamoPcazm_7_GuCEoQ-1 X-Mimecast-MFC-AGG-ID: B9KXQamoPcazm_7_GuCEoQ_1782125763 To: devel@lists.libvirt.org Subject: [PATCH] virsh: Add completer for '--type' option of 'attach-interface' command Date: Mon, 22 Jun 2026 12:56:00 +0200 Message-ID: <3e0a1eecb109a0080f2df591824d4d9f4b896b3e.1782125760.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BLhTqflPGbMJXpk1Q2uGQycRhFb2WVVcHEOmuN9RZwA_1782125763 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: RQEZKGC45V47BSEOZKVIHXFGNQAWLIJV X-Message-ID-Hash: RQEZKGC45V47BSEOZKVIHXFGNQAWLIJV X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1782125825860158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The '--type' option of 'attach-interface' command is translated from string into int using virDomainNetTypeFromString(), IOW the expected value is from virDomainNetType enum. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- tools/virsh-completer-domain.c | 13 +++++++++++++ tools/virsh-completer-domain.h | 5 +++++ tools/virsh-domain.c | 1 + 3 files changed, 19 insertions(+) diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index 912826c434..8bdf68ac09 100644 --- a/tools/virsh-completer-domain.c +++ b/tools/virsh-completer-domain.c @@ -35,6 +35,7 @@ #include "virkeynametable_linux.h" #include "virkeynametable_osx.h" #include "virkeynametable_win32.h" +#include "conf/domain_conf.h" #include "conf/storage_conf.h" #include "conf/numa_conf.h" =20 @@ -1119,3 +1120,15 @@ virshDomainDirtyRateCalcModeCompleter(vshControl *ct= l G_GNUC_UNUSED, return vshEnumComplete(VIRSH_DOMAIN_DIRTYRATE_CALC_MODE_LAST, virshDomainDirtyRateCalcModeTypeToString); } + + +char ** +virshDomainNetTypeCompleter(vshControl *ctl G_GNUC_UNUSED, + const vshCmd *cmd G_GNUC_UNUSED, + unsigned int flags) +{ + virCheckFlags(0, NULL); + + return vshEnumComplete(VIR_DOMAIN_NET_TYPE_LAST, + virDomainNetTypeToString); +} diff --git a/tools/virsh-completer-domain.h b/tools/virsh-completer-domain.h index f5cda4dd15..dfbc10acaa 100644 --- a/tools/virsh-completer-domain.h +++ b/tools/virsh-completer-domain.h @@ -199,3 +199,8 @@ char ** virshDomainDirtyRateCalcModeCompleter(vshControl *ctl, const vshCmd *cmd, unsigned int flags); + +char ** +virshDomainNetTypeCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags); diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 8a6f868e34..aa4f2a7a48 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -837,6 +837,7 @@ static const vshCmdOptDef opts_attach_interface[] =3D { .type =3D VSH_OT_STRING, .positional =3D true, .required =3D true, + .completer =3D virshDomainNetTypeCompleter, .help =3D N_("network interface type") }, {.name =3D "source", --=20 2.53.0