From nobody Sun Dec 22 01:18:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1685028853; cv=none; d=zohomail.com; s=zohoarc; b=JRZzdqLlcJHMlyTP7LYo75HKOqRkzKK9FKGfPwPHN5SoWuh212nXAlteRhSz9M7aRK7ufeQ5CM6koHQave9SV2gEH1rP3E9/J1TYibDioWDaGzaTMDXAurTnhJQbFOKh4P9bRJqiJCp9IKIFGLboUVRI/KOfQSxBjKlyEnfWQtg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1685028853; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mA8RkTeKV8OYsaCkUqqkit0tbbgdfvSQ7j0WMOAT9ZI=; b=LumDgo1O5rqlCTrWpgWtsf6/h9ISMlwhPCADio1a3KBGZ60f7LK1/AkXS9ehb/oE4XMp5z8wF+bwVyAqmkNqFbvgvlcYKanVyRASVGieQ9xcLdVtRUVbIfOJDX1P4HatHLYq+j6NaX0ca1rd4cTyj0NY+CgdvR2qQOVS0Kd+2Pg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1685028853026679.8096138043836; Thu, 25 May 2023 08:34:13 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-563-c1JE05gJP1GfC4sIsaZA9A-1; Thu, 25 May 2023 11:34:08 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 97225101AA6E; Thu, 25 May 2023 15:34:05 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 40BDE2166B31; Thu, 25 May 2023 15:34:05 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 73F3219465BC; Thu, 25 May 2023 15:33:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 09E491946A41 for ; Thu, 25 May 2023 15:14:02 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 43500417E4E; Thu, 25 May 2023 15:13:58 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id C00EF43E903 for ; Thu, 25 May 2023 15:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685028851; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=mA8RkTeKV8OYsaCkUqqkit0tbbgdfvSQ7j0WMOAT9ZI=; b=V5C1aRWQPNlw2nyNXiJgJGeZ7zIehBpphrgLxJOonj5cfevAgDkObOaht15peouaTaqe9P qeC22lgPeJvCRjjV6TW6LoL0OBdWVJ8hOGB7tvQhuuWf6RmIAv6+7OcfqrqHiZ7wwXdpX7 bQrGB4Ksa+TRe6U2gfNrQ4yBY3eeB+Y= X-MC-Unique: c1JE05gJP1GfC4sIsaZA9A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 13/18] qemuDiskConfigBlkdeviotuneEnabled: Make 'disk' argument const Date: Thu, 25 May 2023 17:13:40 +0200 Message-Id: <3df14f26a752d0af7f10fc5659c7d3f3b844ffdb.1685027511.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1685028854553100001 Content-Type: text/plain; charset="utf-8" The function doesn't modify it. Fix the argument declaration so that the function can be used in a context where we have a 'const' disk definition. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_command.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 15383f646a..cdaa77dcbc 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1550,7 +1550,7 @@ qemuBuildChardevCommand(virCommand *cmd, bool -qemuDiskConfigBlkdeviotuneEnabled(virDomainDiskDef *disk) +qemuDiskConfigBlkdeviotuneEnabled(const virDomainDiskDef *disk) { return !!disk->blkdeviotune.group_name || virDomainBlockIoTuneInfoHasAny(&disk->blkdeviotune); diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h index 5fdb138030..55efa45601 100644 --- a/src/qemu/qemu_command.h +++ b/src/qemu/qemu_command.h @@ -208,7 +208,7 @@ qemuBuildZPCIDevProps(virDomainDeviceInfo *dev); int qemuNetworkPrepareDevices(virDomainDef *def); bool -qemuDiskConfigBlkdeviotuneEnabled(virDomainDiskDef *disk); +qemuDiskConfigBlkdeviotuneEnabled(const virDomainDiskDef *disk); virJSONValue *qemuBuildHotpluggableCPUProps(const virDomainVcpuDef *vcpu) ATTRIBUTE_NONNULL(1); --=20 2.40.1