From nobody Fri Jul 24 05:22:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1784820329; cv=none; d=zohomail.com; s=zohoarc; b=V280wVI+t/YpSNt9PntQq37unpZOYazaG17wzvsBC+mkJS63VvpMc+sTq0hnXctF77rl61wIdo3dMroEjBtvf2YW0X30IYdNEOQXBh8iFqg9a2k4FYgAaxuBDUfXKOA0fb8rjXb99763IT4mPMQmYrfNQqm5rlmoxVD2e9exNrg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784820329; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=7Wgt+AUfpQyYZ/qgS8AlNZ4kmQHcRbTwcdd7oR9zrmY=; b=SNYcyNJ6tb1BxUFSIzEA0G2yt4ZwXQKu2kggZw51BnOoPMDxe6RGTktTR/acTZ2EsRI1AfA2oiW2lUjYJyyS3dIngAy8VoA9jM5et2M9TDZYj5sIrmTVXsge4tZwvEMTpMOu0zEUJh/3wsHLVa01bWFXMyYE37ACxl1+EMs0jVs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1784820329566887.2042572325731; Thu, 23 Jul 2026 08:25:29 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 3DA3A41B4A; Thu, 23 Jul 2026 11:25:28 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 0887A419A3; Thu, 23 Jul 2026 11:24:44 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 3D645419CF; Thu, 23 Jul 2026 11:24:35 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 09BF6419CF for ; Thu, 23 Jul 2026 11:24:33 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-AaNdQ558NXOO7WU7nOV4_A-1; Thu, 23 Jul 2026 11:24:31 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1479C1944DCE for ; Thu, 23 Jul 2026 15:24:31 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.44.48.56]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 12AE91956054 for ; Thu, 23 Jul 2026 15:24:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784820273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7Wgt+AUfpQyYZ/qgS8AlNZ4kmQHcRbTwcdd7oR9zrmY=; b=JOIZSq2vsvUXxLOWhpUfcHN9HJZQW3Ow7/YCbY65AES8OaEMwKWV+T57WwLz9WnFdALMIw rQZs+OBeEvcmTOKoCANGw00LOdQppGZ5A4nHEvdF7V/l8psyUz7qE9k7L9WH5coECXURw/ wI+iAHMJ9D+mXZ+rOXTDTW6t764R5+I= X-MC-Unique: AaNdQ558NXOO7WU7nOV4_A-1 X-Mimecast-MFC-AGG-ID: AaNdQ558NXOO7WU7nOV4_A_1784820271 To: devel@lists.libvirt.org Subject: [libvirt PATCH] build: Check for directory in the git_werror check Date: Thu, 23 Jul 2026 17:24:22 +0200 Message-ID: <3df014f591588c43b601570203efb8b743c6d9a0.1784820262.git.jtomko@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bci5VH6zbYYnVFyF3oqeDoT_82qgBHjDTjtD_VQu8pY_1784820271 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: OW5VR53G34N4LTUFRRAZLUDQ2345KGP7 X-Message-ID-Hash: OW5VR53G34N4LTUFRRAZLUDQ2345KGP7 X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?J=C3=A1n_Tomko_via_Devel?= Reply-To: =?UTF-8?q?J=C3=A1n=20Tomko?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1784820331588158500 From: Jordan Petridis test -e will only check if something exists, but -d is more appropriate as it will check that it exists and is also a directory. Signed-off-by: Jordan Petridis Reviewed-by: J=C3=A1n Tomko --- Pushed meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index ad1a5da1a5..6d5085042c 100644 --- a/meson.build +++ b/meson.build @@ -21,7 +21,7 @@ po_dir =3D meson.project_source_root() / 'po' =20 # figure out if we are building from git =20 -git =3D run_command('test', '-e', '.git', check: false).returncode() =3D= =3D 0 +git =3D run_command('test', '-d', '.git', check: false).returncode() =3D= =3D 0 =20 if git and not get_option('no_git') run_command('git', 'submodule', 'update', '--init', check: true) --=20 2.55.0