From nobody Mon Feb 9 22:26:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1748332348; cv=none; d=zohomail.com; s=zohoarc; b=O8/0Nfjls2UFpGLs9Dl3AeE+DimwWkDLVA0r/N2dng4wT8HpwGCWoF/ajTMNgSB8Ziy7NyM6Mrs1j4SzIfqvydFNSSbyZKpsvzvsrEKJkfmB7AMlcvzfLsY0OHhaHq/4YiTOVHoirZbP0fV0XuY8DR2XTDHsGV1/ZPTbEtcBvSA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748332348; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=7gi8R69oda+J+I2MuOYFXFa0D21/f1S6iTryw4zqFY8=; b=aoyLCIbMSr5vZogXe6Q0FXPBlKdfj3XhvOJpL7ODjI5HzzM2VdRYUSxVPiR8P6eahbOdBzWl8qz37V/oSaidaaimrEl79TTmFXFOCuGzb4C4QP/6AOBEdgzr4DtzeLIUBq42NWUfcTmluYYG3VSMbrnb+C2bN660W12PPN0wBgc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748332348354380.29541151388094; Tue, 27 May 2025 00:52:28 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 5D52414BA; Tue, 27 May 2025 03:52:27 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 17540177B; Tue, 27 May 2025 03:49:42 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 8B43A163B; Tue, 27 May 2025 03:49:34 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 66A9516E8 for ; Tue, 27 May 2025 03:49:20 -0400 (EDT) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-18-fdvzdKrwPC69cdJe1uK9BA-1; Tue, 27 May 2025 03:49:17 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C6D8A1955DAD for ; Tue, 27 May 2025 07:49:16 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.3]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E1D20180047F for ; Tue, 27 May 2025 07:49:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748332160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hf0mlKBzMoHrtri8XSNeKwZxuWb7sgm1v7hq2VMLci0=; b=OMgQnrykyLiwAvTG3S5z0xQlLBhgWbB8awG5rXVj0sf9nCo/f+/lq264DlXpFqktESOZln +QTJz70udKKERc1QGVNl/ecGiu5WBxjd7C4wNyYeJ+0bEGx5WoqP3Tba4fJeMDYMaU2384 ezDkrOSOiV84rScQeG+PTDc2PKwoIdQ= X-MC-Unique: fdvzdKrwPC69cdJe1uK9BA-1 X-Mimecast-MFC-AGG-ID: fdvzdKrwPC69cdJe1uK9BA_1748332156 To: devel@lists.libvirt.org Subject: [PATCH 7/9] qemu: Move checks for number of listening sockets of graphics to validation code Date: Tue, 27 May 2025 09:49:03 +0200 Message-ID: <3dc427090f90a687e445ab57fcb7f3a056070352.1748332058.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: d9Rtxr9B_-uv9ctccV_X4il1k-zyWzJVQmpTjdK6oxA_1748332156 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: EAQPR4ZO3Y4SW6MMXWWURZ5MPG7JL3GK X-Message-ID-Hash: EAQPR4ZO3Y4SW6MMXWWURZ5MPG7JL3GK X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748332350570116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Move the checks from 'qemuProcessStartValidateGraphics' to the correspodning graphics validation functions in qemu_validate.c: - qemuValidateDomainDeviceDefSPICEGraphics - qemuValidateDomainDeviceDefVNCGraphics - qemuValidateDomainDeviceDefRDPGraphics Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 10 ---------- src/qemu/qemu_validate.c | 18 ++++++++++++++++++ 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 9fbb03ee8b..b99602c5ed 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -5537,19 +5537,9 @@ qemuProcessStartValidateGraphics(virDomainObj *vm) switch (graphics->type) { case VIR_DOMAIN_GRAPHICS_TYPE_VNC: case VIR_DOMAIN_GRAPHICS_TYPE_SPICE: - if (graphics->nListens > 1) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("QEMU does not support multiple listens f= or one graphics device.")); - return -1; - } break; case VIR_DOMAIN_GRAPHICS_TYPE_RDP: - if (graphics->nListens > 1) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("qemu-rdp does not support multiple liste= ns for one graphics device.")); - return -1; - } if (graphics->data.rdp.multiUser) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("qemu-rdp doesn't support the 'multiUser'= attribute.")); diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 0e7dd3fc58..1aa54bf59f 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -4425,6 +4425,12 @@ qemuValidateDomainDeviceDefSPICEGraphics(const virDo= mainGraphicsDef *graphics, virDomainGraphicsListenDef *glisten =3D NULL; int tlsPort =3D graphics->data.spice.tlsPort; + if (graphics->nListens > 1) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("QEMU does not support multiple listens for one g= raphics device.")); + return -1; + } + glisten =3D virDomainGraphicsGetListen((virDomainGraphicsDef *)graphic= s, 0); if (!glisten) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", @@ -4472,6 +4478,12 @@ static int qemuValidateDomainDeviceDefVNCGraphics(const virDomainGraphicsDef *graphic= s, virQEMUCaps *qemuCaps) { + if (graphics->nListens > 1) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("QEMU does not support multiple listens for one g= raphics device.")); + return -1; + } + if (graphics->data.vnc.powerControl !=3D VIR_TRISTATE_BOOL_ABSENT && !virQEMUCapsGet(qemuCaps, QEMU_CAPS_VNC_POWER_CONTROL)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", @@ -4512,6 +4524,12 @@ qemuValidateDomainDeviceDefDBusGraphics(const virDom= ainGraphicsDef *graphics, static int qemuValidateDomainDeviceDefRDPGraphics(const virDomainGraphicsDef *graphic= s) { + if (graphics->nListens > 1) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("qemu-rdp does not support multiple listens for o= ne graphics device.")); + return -1; + } + if (graphics->data.rdp.replaceUser) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("RDP doesn't support 'replaceUser'")); --=20 2.49.0