From nobody Mon Feb 9 10:39:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1569331084; cv=none; d=zoho.com; s=zohoarc; b=Im/E6IwrOO71qd/Xj2RXZJu+niof3ybtLjq8jVKbiKwI5mBIbfYKMKHZgcH3dgbO882npGFhWAJFH/SACdrUs7mw9/URfJFNI0syY340J4UMacxnwEpDMYr9Upl/qr6EBvSnRnLwYXTOr7aZwlHq8zqPQCAZGIXGkEwdj01u0Lg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569331084; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=kPUtPPIBvPpcD9Gd3jJyNM8/9stfzRqIx7wwwgImRBk=; b=Gq/WevMi8YZmX6JfS1cwnnHVoko95suMF9cfP/xSAfMvZjRuN/MKUOCi2hKFDGYlbw4C8Q9cdB2EIuF4c4FyNxJF775wBc5Q+btz08wjYy/3IGBuxJFQd0/ej29cK0D4/GHoYG/vSIo+WSPJK7zwtb89suxwnjBSNDDvR1SniSo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 156933108495354.510223664057776; Tue, 24 Sep 2019 06:18:04 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 580F020F3; Tue, 24 Sep 2019 13:18:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 329F94521; Tue, 24 Sep 2019 13:18:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E7A7A62D11; Tue, 24 Sep 2019 13:18:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x8ODHt24019548 for ; Tue, 24 Sep 2019 09:17:55 -0400 Received: by smtp.corp.redhat.com (Postfix) id 30D1719C70; Tue, 24 Sep 2019 13:17:55 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id ADC0A19C6A for ; Tue, 24 Sep 2019 13:17:54 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Tue, 24 Sep 2019 15:17:47 +0200 Message-Id: <3c2aabad44976551031b419c701f03aa30d57265.1569330948.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/4] qemu: snapshot: Don't forbid snapshot if autodestroy is registered X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.71]); Tue, 24 Sep 2019 13:18:02 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Semantically VIR_DOMAIN_START_AUTODESTROY doesn't really clash with snapshot operations as the VM stays on the same host and thus bound to the same connection. Saving the state also doesn't differ from modifying the state of the VM which is allowed. Remove the check as it doesn't make much sense. Signed-off-by: Peter Krempa Reviewed-by: Eric Blake --- src/qemu/qemu_driver.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f7f059b6d6..823aa558ac 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -15917,12 +15917,6 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain, if (!(caps =3D virQEMUDriverGetCapabilities(driver, false))) goto cleanup; - if (qemuProcessAutoDestroyActive(driver, vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is marked for auto destroy")); - goto cleanup; - } - if (!vm->persistent && (flags & VIR_DOMAIN_SNAPSHOT_CREATE_HALT)) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("cannot halt after transient domain snapshot")); --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list