[libvirt PATCH] libxl: do not include math.h

Ján Tomko posted 1 patch 3 years, 7 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/3bd129870985d16d027b6e2dfc73f26e35f2ad82.1598533351.git.jtomko@redhat.com
src/libxl/libxl_driver.c | 1 -
1 file changed, 1 deletion(-)
[libvirt PATCH] libxl: do not include math.h
Posted by Ján Tomko 3 years, 7 months ago
The include was introduced by:
  commit 3d6fe99c5c3b862db1b345da3598a920f1079b6e
    Add vcpu functions to libxl driver
which used ceil() and floor(), but these were later
removed by:
  commit 3eb869a04bdeaddbe10e74568540e865fb79e412
    libxl: avoid compiler warning
which did not remove the include.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/libxl/libxl_driver.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index dc602ea162..31f2531162 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
@@ -22,7 +22,6 @@
 
 #include <config.h>
 
-#include <math.h>
 #include <libxl.h>
 #include <libxl_utils.h>
 #include <xenstore.h>
-- 
2.26.2

Re: [libvirt PATCH] libxl: do not include math.h
Posted by Jim Fehlig 3 years, 7 months ago
On 8/27/20 7:02 AM, Ján Tomko wrote:
> The include was introduced by:
>    commit 3d6fe99c5c3b862db1b345da3598a920f1079b6e
>      Add vcpu functions to libxl driver
> which used ceil() and floor(), but these were later
> removed by:
>    commit 3eb869a04bdeaddbe10e74568540e865fb79e412
>      libxl: avoid compiler warning
> which did not remove the include.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>   src/libxl/libxl_driver.c | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Jim Fehlig <jfehlig@suse.com>

Regards,
Jim