From nobody Mon Sep 21 19:09:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1783602601; cv=none; d=zohomail.com; s=zohoarc; b=W/J2h8wdlylYLMmvHCvQxo8aFWjPrX59XlIwjwtz337wVIWXaBwK17JyzOp+4AfkqNcPl5s/KYCc9XtqYNURqSMhcsPi2Pxq9OA9QkUm/6QU9v9u6trerJT24emC6cMzOGYb8SQnM5tykw0qvPHgEvzcdZusJW2GMkIKNX8we3s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783602601; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=aLWHDx9TpRyqqQGVVtZe2+0omODp/C9GCLlTe7PV9ic=; b=mglmCG4Rvh6ZcBif8XoqQaHJOUj87H6Pou2xTKzG1g12W4XkraiUMxw7e/rBb9mnGsMV/JGPx7QfKdFuxmjHSU4aw1jCp4vY273q45XAV8aeMRydvQE5VNN+TFhaYbFLwYYKMPOZI/OuJmzVZfoCCseNCzNAwtdoppGWYs0n7hA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1783602601521410.5601641094578; Thu, 9 Jul 2026 06:10:01 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 3163541C4F; Thu, 9 Jul 2026 09:10:00 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 851F041BC1; Thu, 9 Jul 2026 09:06:32 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 51F5941A4E; Thu, 9 Jul 2026 09:06:01 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id F379041A4E for ; Thu, 9 Jul 2026 09:05:59 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-7ZNXWaqFMwSiWEiouMoXOQ-1; Thu, 09 Jul 2026 09:05:58 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2EB7618009DF for ; Thu, 9 Jul 2026 13:05:57 +0000 (UTC) Received: from rsmigiel-thinkpadx1carbongen11-remote-csb.redhat.com (unknown [10.44.33.224]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4497B36933; Thu, 9 Jul 2026 13:05:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783602359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aLWHDx9TpRyqqQGVVtZe2+0omODp/C9GCLlTe7PV9ic=; b=DiW7CFz1KaltZHRtx+25o71mp4XFlfXXf2XbvRz/Sta+yJDam+0dwX5YZviLiL5iz1M2ai nnI+9u8t8T9nQCcT1nIUYX3mGLlK1X6YmN4djuLMqN9xyaSXro+9O6FLtHISGHByRg+GB7 h9IuYnRe3vldMkP7qWPloDqSKIZKY8M= X-MC-Unique: 7ZNXWaqFMwSiWEiouMoXOQ-1 X-Mimecast-MFC-AGG-ID: 7ZNXWaqFMwSiWEiouMoXOQ_1783602357 To: devel@lists.libvirt.org Subject: [PATCH 3/6] virsh: Add completer for '--type' option of 'detach-interface' command Date: Thu, 9 Jul 2026 15:00:59 +0200 Message-ID: <3b7d3c46eaba6e7f6d2e0fc51503003a273a79b5.1783602062.git.rsmigiel@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: --FIgwbQUEqIxQsfHT4_WqXbKB6sIGA46W8_aC3bUOc_1783602357 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: C4CPW7ZOI6PK5TH7CBJ33TNF2KJI3JDE X-Message-ID-Hash: C4CPW7ZOI6PK5TH7CBJ33TNF2KJI3JDE X-MailFrom: rsmigiel@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Radoslaw Smigielski X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Rados=C5=82aw_=C5=9Amigielski_via_Devel?= Reply-To: rsmigiel@redhat.com X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1783602603031158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Radoslaw Smigielski The '--type' option of 'detach-interface' command specifies the network interface type to detach. Partially-fixes: https://gitlab.com/libvirt/libvirt/-/work_items/9 Signed-off-by: Radoslaw Smigielski Reviewed-by: Peter Krempa --- tools/virsh-domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index e6f2ca3a449a..79823072ad26 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -12785,6 +12785,7 @@ static const vshCmdOptDef opts_detach_interface[] = =3D { {.name =3D "type", .type =3D VSH_OT_STRING, .positional =3D true, + .completer =3D virshDomainNetTypeCompleter, .help =3D N_("network interface type") }, {.name =3D "mac", --=20 2.54.0