From nobody Mon Feb 9 01:48:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618835970; cv=none; d=zohomail.com; s=zohoarc; b=nF85okXn6vbxytVQfofa63vNTLguzowCIHyvvRdK2ecGiPd2s5wfh4Z7BOI0hPMDALDKGMWpxnuzBkrhRIKagdUoGmCHVBiBUNCGYKidKOGshbFZGOlaUmCTpMF8XRiivm7oR9c3qoS3km9aGSNk0Nw5mRQ3zpW6+bXaCeoRAEQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618835970; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lcoLSFNNL6w54/CQsbZwy6H7MfVztyK3tC+FjYsDTYw=; b=NErQD1OCRX2Zhlx1sKH3ui3wwCV6hvyvLbYvkYwexLIUDujoS0GzxC3D/cXfBIT0uqz08q1Th/NPfUStEQ5lgcJORsV1cFiJE476K3jXP1mMpV/kWKS0bA5ZIdFTGk6XMRyZxP5oQIf8E82us+mJmCWiQJR/RtWpOVhNm44RKq8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1618835970155775.7687091915711; Mon, 19 Apr 2021 05:39:30 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-344-UB3bCci_PHCSPc6RvTNNlg-1; Mon, 19 Apr 2021 08:39:26 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B43DA107ACCA; Mon, 19 Apr 2021 12:39:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 823D410016FE; Mon, 19 Apr 2021 12:39:21 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 478A31806D21; Mon, 19 Apr 2021 12:39:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13JCa1am019108 for ; Mon, 19 Apr 2021 08:36:01 -0400 Received: by smtp.corp.redhat.com (Postfix) id A2C8A19C66; Mon, 19 Apr 2021 12:36:01 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 15937E730 for ; Mon, 19 Apr 2021 12:36:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618835969; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lcoLSFNNL6w54/CQsbZwy6H7MfVztyK3tC+FjYsDTYw=; b=eA8u4V9+tzVQyaLzuY4HuP8AQ/0qO/H1ZD3zNthHR1/915cLm0WGVggaPhIW8nvHA4gIl4 rHL5oKXrX9fPdJmB+zbGU29oVb4N3/fMODXWJHAH4mo8B0liPJi4RKFBFVZT9S+tpjBn0i SlhXpy5hLK7B0MRSQ7Y/B86CpjkP7mE= X-MC-Unique: UB3bCci_PHCSPc6RvTNNlg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 11/38] qemu: capabilities: Move setting of QEMU_CAPS_CPU_AARCH64_OFF to virQEMUCapsInitQMPBasicArch Date: Mon, 19 Apr 2021 14:35:15 +0200 Message-Id: <3aa07cbbac30e7070f8ee5c10a861d86b93e8362.1618834490.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" It's now always set for AARCH64, move it into the function setting basic caps for the emulator. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- src/qemu/qemu_capabilities.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 317aba02ab..fd69a5e8d5 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -5054,6 +5054,9 @@ virQEMUCapsInitQMPBasicArch(virQEMUCaps *qemuCaps) case VIR_ARCH_AARCH64: /* ACPI only works on x86 and aarch64 */ virQEMUCapsSet(qemuCaps, QEMU_CAPS_NO_ACPI); + + /* -cpu ...,aarch64=3Doff is not detectable via qmp at this point = */ + virQEMUCapsSet(qemuCaps, QEMU_CAPS_CPU_AARCH64_OFF); break; case VIR_ARCH_PPC64: @@ -5117,11 +5120,6 @@ virQEMUCapsInitQMPVersionCaps(virQEMUCaps *qemuCaps) virQEMUCapsSet(qemuCaps, QEMU_CAPS_EGL_HEADLESS); virQEMUCapsSet(qemuCaps, QEMU_CAPS_NUMA_DIST); - /* -cpu ...,aarch64=3Doff supported in v2.3.0 and onwards. But it - isn't detectable via qmp at this point */ - if (qemuCaps->arch =3D=3D VIR_ARCH_AARCH64) - virQEMUCapsSet(qemuCaps, QEMU_CAPS_CPU_AARCH64_OFF); - if (ARCH_IS_PPC64(qemuCaps->arch)) { /* HPT resizing is supported since QEMU 2.10 on ppc64; unfortunate= ly * there's no sane way to probe for it */ --=20 2.30.2