From nobody Sun Feb 8 22:17:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1639053243; cv=none; d=zohomail.com; s=zohoarc; b=dEUoBrJYWCNcTgU9/x+13kieYXeBy/3W7uI9DfzHOU23b/FRXvhuL76QadVxyrOdhbIt2S0jpKTQfvLMpFHbzYq7kqv0b2/1W97FJdC0uSbJv7HefPDS3mXQ8A9ZvP0iyoOqyMhR64aFRWe4DVkylmnx6TkPqboIiinqtYJrw5g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639053243; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=diQiNMzZjo9lhFwXgygM2PVBCeU+G9/G1nYp2jXVvyg=; b=VjljrUyYYY/qglxkjkHWlFyWe2FhvOD+Z8kxLUdyL0VhZDO9YKruYSubAak/NsZsohsTc6kStuj+N+DeJI1EdcCXiz0SveIailAF2POLV3tvrGGi74cBzm3jFYBGzyiaJ/ajkS6KtZ5ErEZFl6y7VmuncmePItDRjvUgHeTbUtI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 16390532430671.2662657457012756; Thu, 9 Dec 2021 04:34:03 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-587-U-g-EaWlMxmWtKfRiBM-Zg-1; Thu, 09 Dec 2021 07:33:43 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 609F11018757; Thu, 9 Dec 2021 12:33:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4716C45D83; Thu, 9 Dec 2021 12:33:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9EF724A708; Thu, 9 Dec 2021 12:33:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B9CV3G5017603 for ; Thu, 9 Dec 2021 07:31:03 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5BDD14ABA1; Thu, 9 Dec 2021 12:31:03 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id B6DFD1B472 for ; Thu, 9 Dec 2021 12:31:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639053242; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=diQiNMzZjo9lhFwXgygM2PVBCeU+G9/G1nYp2jXVvyg=; b=B1vQMNDPTbNSSeQ5ogykdlWVWhHc24GksVm+FaPq4dghrftCg9dz/QrLK8CTIYT2vej8ap rcGVtzB+swjP8RuLVdo2f0ivx7qgR6LdDoBgmqMaDlzUSywrhi44rTrSx6a3UxRozqD/Uk ZMBR9g4y53T291TvDXECFFa4IRQxx0A= X-MC-Unique: U-g-EaWlMxmWtKfRiBM-Zg-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 02/24] qemu: domain: Introduce helpers for initializing chardev backend of devices Date: Thu, 9 Dec 2021 13:30:37 +0100 Message-Id: <3a8815d2bdf00dc8fb69b239ca31d5856e1aa9cf.1639052639.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1639053243519100001 Content-Type: text/plain; charset="utf-8" Introduce qemuDomainDeviceBackendChardevForeach(One) which calls the callback if either given device has a chardev backend or for all chardev backends of all devices. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_domain.c | 117 +++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_domain.h | 12 +++++ 2 files changed, 129 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 2c10f185f8..4f0d266c73 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -11455,3 +11455,120 @@ qemuDomainGetVHostUserFSSocketPath(qemuDomainObjP= rivate *priv, return virFileBuildPath(priv->libDir, fs->info.alias, "-fs.sock"); } + + +/** + * qemuDomainDeviceBackendChardevForeachOne: + * @dev: device definition + * @cb: callback + * @opaque: data for @cb + * + * Calls @cb with the char device backend data if @dev is a device which h= as a + * chardev backend. + */ +int +qemuDomainDeviceBackendChardevForeachOne(virDomainDeviceDef *dev, + qemuDomainDeviceBackendChardevFor= eachCallback cb, + void *opaque) +{ + switch ((virDomainDeviceType) dev->type) { + case VIR_DOMAIN_DEVICE_NET: + if (virDomainNetGetActualType(dev->data.net) !=3D VIR_DOMAIN_NET_T= YPE_VHOSTUSER) + return 0; + + return cb(dev, dev->data.net->data.vhostuser, opaque); + + case VIR_DOMAIN_DEVICE_REDIRDEV: + return cb(dev, dev->data.redirdev->source, opaque); + + case VIR_DOMAIN_DEVICE_SHMEM: + if (!dev->data.shmem->server.enabled) + return 0; + + return cb(dev, dev->data.shmem->server.chr, opaque); + + case VIR_DOMAIN_DEVICE_CHR: + return cb(dev, dev->data.chr->source, opaque); + + case VIR_DOMAIN_DEVICE_SMARTCARD: + if (dev->data.smartcard->type !=3D VIR_DOMAIN_SMARTCARD_TYPE_PASST= HROUGH) + return 0; + + return cb(dev, dev->data.smartcard->data.passthru, opaque); + + case VIR_DOMAIN_DEVICE_RNG: + if (dev->data.rng->backend !=3D VIR_DOMAIN_RNG_BACKEND_EGD) + return 0; + + return cb(dev, dev->data.rng->source.chardev, opaque); + + case VIR_DOMAIN_DEVICE_DISK: + case VIR_DOMAIN_DEVICE_LEASE: + case VIR_DOMAIN_DEVICE_FS: + case VIR_DOMAIN_DEVICE_INPUT: + case VIR_DOMAIN_DEVICE_SOUND: + case VIR_DOMAIN_DEVICE_VIDEO: + case VIR_DOMAIN_DEVICE_HOSTDEV: + case VIR_DOMAIN_DEVICE_WATCHDOG: + case VIR_DOMAIN_DEVICE_CONTROLLER: + case VIR_DOMAIN_DEVICE_GRAPHICS: + case VIR_DOMAIN_DEVICE_HUB: + case VIR_DOMAIN_DEVICE_NONE: + case VIR_DOMAIN_DEVICE_MEMBALLOON: + case VIR_DOMAIN_DEVICE_NVRAM: + case VIR_DOMAIN_DEVICE_TPM: + case VIR_DOMAIN_DEVICE_PANIC: + case VIR_DOMAIN_DEVICE_LAST: + case VIR_DOMAIN_DEVICE_MEMORY: + case VIR_DOMAIN_DEVICE_IOMMU: + case VIR_DOMAIN_DEVICE_VSOCK: + case VIR_DOMAIN_DEVICE_AUDIO: + /* no chardev backend */ + break; + } + + return 0; +} + +struct qemuDomainDeviceBackendChardevIterData { + qemuDomainDeviceBackendChardevForeachCallback cb; + void *cbdata; +}; + + +static int +qemuDomainDeviceBackendChardevIter(virDomainDef *def G_GNUC_UNUSED, + virDomainDeviceDef *dev, + virDomainDeviceInfo *info G_GNUC_UNUSED, + void *opaque) +{ + struct qemuDomainDeviceBackendChardevIterData *data =3D opaque; + + return qemuDomainDeviceBackendChardevForeachOne(dev, data->cb, data->c= bdata); +} + + +/** + * qemuDomainDeviceBackendChardevForeach:a + * @def: domain definition + * @cb: callback + * @opqaue: data for @cb + * + * Same as qemuDomainDeviceBackendChardevForeachOne called for every devic= e in + * @def. + */ +int +qemuDomainDeviceBackendChardevForeach(virDomainDef *def, + qemuDomainDeviceBackendChardevForeac= hCallback cb, + void *opaque) +{ + struct qemuDomainDeviceBackendChardevIterData data =3D { + .cb =3D cb, + .cbdata =3D opaque, + }; + + return virDomainDeviceInfoIterateFlags(def, + qemuDomainDeviceBackendChardevI= ter, + DOMAIN_DEVICE_ITERATE_MISSING_I= NFO, + &data); +} diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index f2a303d8a7..3de3f70b94 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -1032,3 +1032,15 @@ qemuDomainNamePathsCleanup(virQEMUDriverConfig *cfg, char * qemuDomainGetVHostUserFSSocketPath(qemuDomainObjPrivate *priv, const virDomainFSDef *fs); + +typedef int (*qemuDomainDeviceBackendChardevForeachCallback)(virDomainDevi= ceDef *dev, + virDomainChrS= ourceDef *charsrc, + void *opaque); +int +qemuDomainDeviceBackendChardevForeachOne(virDomainDeviceDef *dev, + qemuDomainDeviceBackendChardevFor= eachCallback cb, + void *opaque); +int +qemuDomainDeviceBackendChardevForeach(virDomainDef *def, + qemuDomainDeviceBackendChardevForeac= hCallback cb, + void *opaque); --=20 2.31.1