From nobody Mon Feb 2 06:00:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1769509215; cv=none; d=zohomail.com; s=zohoarc; b=g+bkxBRj3xSfT6e4l00myka7m5anJHhxARUw6/AISHarYnjTejBaankuf3rPjnb+2qpTP0tqCbA0qHa4TFABgSf3GcO93QoR2ONmtDfJwFyTp5PN9Rld5+9FcpSkiHewkLMP9YiRRGSVBsm+5hnDUWIEO6WnPgE49OZQgHai9Fw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769509215; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=iYMnJjfud62X1vjQngz3X0L7zgDKt43fGxx0uEVZ6Kk=; b=BF+YH2+PJYV4mvmT9byt813NsWAl3tuNMIvD055TywPos9qSGgwoqG4EebRWPRgewxK+ZJas795QOJM1XoaVaZA0ShgD6Mc3Xm4ClaszMpg/trPGGTUK+bntVq5mmStFmn9vkQfBkbK4HAUVrQBJ4u0eMwy8AYTUhDhAlkxMLhs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1769509215608150.69503086889813; Tue, 27 Jan 2026 02:20:15 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 932754196C; Tue, 27 Jan 2026 05:20:14 -0500 (EST) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 33EB041B82; Tue, 27 Jan 2026 05:19:34 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id B0AAE417CF; Tue, 27 Jan 2026 05:19:29 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 403403FA2E for ; Tue, 27 Jan 2026 05:19:28 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-35-7sHrPYMrOVGz682XSaNIbA-1; Tue, 27 Jan 2026 05:19:25 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 260E0180057E for ; Tue, 27 Jan 2026 10:19:25 +0000 (UTC) Received: from antique-work.lan.rosnicka.net (unknown [10.45.224.80]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6FE3918001D5 for ; Tue, 27 Jan 2026 10:19:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769509167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iYMnJjfud62X1vjQngz3X0L7zgDKt43fGxx0uEVZ6Kk=; b=agFnbAGwGQjeLt8MWbaUgxBAJkFYUS4Tj5LXfe742by2eIoDEWFtHZ67Rme8UHWYaYeLAO c2AtZozzihxj+BiSwO2OYHpdRs26iYsHREDmO7gD36Zjp+hZpjsCEHqOLbTC3fOP0ETdv0 tK0dQ0ZQGgvLXq0FxqPkhBDH6NDQpAU= X-MC-Unique: 7sHrPYMrOVGz682XSaNIbA-1 X-Mimecast-MFC-AGG-ID: 7sHrPYMrOVGz682XSaNIbA_1769509165 To: devel@lists.libvirt.org Subject: [libvirt PATCH] virt-aa-helper: replace usage of magic constant Date: Tue, 27 Jan 2026 11:19:23 +0100 Message-ID: <3a4ec475ac233f3be8704b374595fbc197aecaf1.1769509076.git.phrdina@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: knz4pHjD34KLzY6qytoHBOBAt-Wf4roVrlQCMjbfANA_1769509165 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 2YXXGLC5JEKUGQRF6FI22CVINGMF7VLX X-Message-ID-Hash: 2YXXGLC5JEKUGQRF6FI22CVINGMF7VLX X-MailFrom: phrdina@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Pavel Hrdina via Devel Reply-To: Pavel Hrdina X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1769509221917154100 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Pavel Hrdina Signed-off-by: Pavel Hrdina Reviewed-by: Michal Privoznik --- I wonder if we should just drop that argument and use QEMU_DOMAIN_STORAGE_SOURCE_CHAIN_MAX_DEPTH inside the function directly as the only remaining caller with different value is from virstoragetest.c src/security/virt-aa-helper.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 211c34f926..443646c0a1 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -901,12 +901,12 @@ get_files(vahControl * ctl) continue; /* XXX - if we knew the qemu user:group here we could send it in * so that the open could be re-tried as that user:group. - * - * The maximum depth is limited to 200 layers similarly to the qemu - * implementation. */ - if (!disk->src->backingStore) - virStorageSourceGetMetadata(disk->src, -1, -1, 200, false); + if (!disk->src->backingStore) { + virStorageSourceGetMetadata(disk->src, -1, -1, + QEMU_DOMAIN_STORAGE_SOURCE_CHAIN_M= AX_DEPTH, + false); + } =20 /* XXX should handle open errors more careful than just ignoring = them. */ --=20 2.52.0