From nobody Sun Feb 8 20:37:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1628780108; cv=none; d=zohomail.com; s=zohoarc; b=eosrVOZoF5UQVkBdEoOcAsQrYuONnfPqEjAL3c21VV93hAIWjStM3uOosQg1zTwaEXB9sm/PmuPW7QdnikMZCnx5n9i2hYnL5mjyEffrcJDmMEuL8G/v5BvJ7BdkxGlc3xYJBAUjlz1ON/cM2dEkYunaEKO0XCqYMKhve30GhAM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628780108; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6O2iy0bXV4vVcLsDDhcFbtPuCXh+T4a+2OO91ENus54=; b=oCMUIxd3BsCm8IgcllOEuiDeNOubFhL9hjOV+UH/DazryDy4JjOYe5tKRsehDm/5O4L6zsWK+Zj7lAuSoSu+FmYBsD4H3kRyl6DQLLNxvfup4QgMqSQkGXY14ZaiZqx1u1XCKjPBqkvEt8D+o9S6W/97ZZDM9yT6F8e/ZqAcia0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1628780108337156.96861457190528; Thu, 12 Aug 2021 07:55:08 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-594-pXmcj_ebPU6e0tsOe0ggFA-1; Thu, 12 Aug 2021 10:55:04 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7A684C7403; Thu, 12 Aug 2021 14:54:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FE2D5D9D5; Thu, 12 Aug 2021 14:54:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EFFE44A700; Thu, 12 Aug 2021 14:54:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 17CEnfmg008539 for ; Thu, 12 Aug 2021 10:49:41 -0400 Received: by smtp.corp.redhat.com (Postfix) id 56D7519D9F; Thu, 12 Aug 2021 14:49:41 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id ADDAC19C44 for ; Thu, 12 Aug 2021 14:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628780107; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=6O2iy0bXV4vVcLsDDhcFbtPuCXh+T4a+2OO91ENus54=; b=gCv3VUzsjvAK5LX2seJEs2/4DFJkFUkPALxu3D/JhV9pWrQHQQe5aHpYsMIrxAAwcZNOZf 4MEDYtuN/bama2JC9noCTJFd6kdCumj5Fv0ZeWKOU4OIx4IZbbPxFewD3Rn86I/Z1QWdcy duf2LVdHraAlUb93CMTxfqScBLpoJpM= X-MC-Unique: pXmcj_ebPU6e0tsOe0ggFA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 15/22] qemu: capabilities: Add alternative detection of QEMU_CAPS_NUMA Date: Thu, 12 Aug 2021 16:49:08 +0200 Message-Id: <3a203cf7c8569e276a04b4420bb9db838b4b4cf3.1628778754.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1628780109374100001 Content-Type: text/plain; charset="utf-8" 'set-numa-node' is the command which can set the equivalent parameters to '-numa' in preconfig mode, so we can use it as witness to see that -numa is supported. To ensure that the old detection method is removed once we'll be bumping qemu support add a comment with the appropriate version check. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index abd5f0a0d0..cc92ab098b 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1183,6 +1183,7 @@ struct virQEMUCapsStringFlags virQEMUCapsCommands[] = =3D { { "block-export-add", QEMU_CAPS_BLOCK_EXPORT_ADD }, { "query-display-options", QEMU_CAPS_QUERY_DISPLAY_OPTIONS }, { "blockdev-reopen", QEMU_CAPS_BLOCKDEV_REOPEN }, + { "set-numa-node", QEMU_CAPS_NUMA }, }; struct virQEMUCapsStringFlags virQEMUCapsMigration[] =3D { @@ -3247,7 +3248,7 @@ static struct virQEMUCapsCommandLineProps virQEMUCaps= CommandLine[] =3D { { "msg", "timestamp", QEMU_CAPS_MSG_TIMESTAMP }, { "name", "debug-threads", QEMU_CAPS_NAME_DEBUG_THREADS }, { "name", "guest", QEMU_CAPS_NAME_GUEST }, - { "numa", NULL, QEMU_CAPS_NUMA }, + { "numa", NULL, QEMU_CAPS_NUMA }, /* (qemuCaps->version < 3000000) */ { "overcommit", NULL, QEMU_CAPS_OVERCOMMIT }, { "sandbox", "enable", QEMU_CAPS_SECCOMP_SANDBOX }, { "sandbox", "elevateprivileges", QEMU_CAPS_SECCOMP_BLACKLIST }, --=20 2.31.1