From nobody Mon Feb 9 13:37:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617285377; cv=none; d=zohomail.com; s=zohoarc; b=kXj28dKxtf+1oGAI12viXYG3Ye5asVHjUzVEyLDVWy0O5ReCpbuVig1PY0FgNAxnG6/mNvOmbioNq99EbiuRSD7qVvpVExmdKc822y55+MzS3aO54Pmq8j7NF50sjelLojdPr9k64DpT+FQPYJnCObpyOWzI+8qbWlDGXmQvh1I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617285377; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=e2YJMXl+ExqKEKVhP32VAEz6KLQuYA5qDFQ6vg1b+f0=; b=GMCHk1/BxRQ+ZQmrDtCkghlQFvFFv1DvDzm+WXV2G4bPLkbHSWJh7H66i4/BsdWP5QcmZrQgR5o9JGQG/aKsrxwwbAKsAvyS9U3uzxfF+fIguXJFf8Zbc6nDDKOMy58ggwW91ejFo4J6vnn/CjKVyY9LtuQt30mCDDYlol6cxAY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1617285377590449.83344322986795; Thu, 1 Apr 2021 06:56:17 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-603-NrQ1TdDJM7eWDlJF2zwEUw-1; Thu, 01 Apr 2021 09:54:15 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0EAFDCC639; Thu, 1 Apr 2021 13:54:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5FE0776E39; Thu, 1 Apr 2021 13:54:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EDE7A18155DD; Thu, 1 Apr 2021 13:53:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 131DrxtV023276 for ; Thu, 1 Apr 2021 09:53:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id 61D59794D8; Thu, 1 Apr 2021 13:53:57 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9DB23795B4 for ; Thu, 1 Apr 2021 13:53:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617285376; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=e2YJMXl+ExqKEKVhP32VAEz6KLQuYA5qDFQ6vg1b+f0=; b=MTzWdiVYDnP6bho1TF+YuLno5xcRvgWuv26Iz/u8rjwujUdCJhtL7ufHp7tp5Ah6YEOoxN 7QMBAXvPyxYIotpzTJbsyh2uMKZOaRkHEYo8qK+Nwf8otfR1WZxRwI5zYZL4nXE/PPjFfG RFzNL1fjjdf7TjTg4iLVKALjT5MmAms= X-MC-Unique: NrQ1TdDJM7eWDlJF2zwEUw-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 15/39] virLogParseFilter: Replace virStringSplitCount by g_strsplit Date: Thu, 1 Apr 2021 15:52:14 +0200 Message-Id: <39e57196edab90441e3408342d25b404bb86b900.1617285119.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" We don't really need the count. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/util/virlog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 57eb0de538..8a4cfbfdc2 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -1556,7 +1556,6 @@ virLogParseOutput(const char *src) virLogFilterPtr virLogParseFilter(const char *src) { - size_t count =3D 0; virLogPriority prio; g_auto(GStrv) tokens =3D NULL; char *match =3D NULL; @@ -1564,7 +1563,8 @@ virLogParseFilter(const char *src) VIR_DEBUG("filter=3D%s", src); /* split our format prio:match_str to tokens and parse them individual= ly */ - if (!(tokens =3D virStringSplitCount(src, ":", 0, &count)) || count != =3D 2) { + if (!(tokens =3D g_strsplit(src, ":", 0)) || + !tokens[0] || !tokens[1]) { virReportError(VIR_ERR_INVALID_ARG, _("Malformed format for filter '%s'"), src); return NULL; --=20 2.29.2