From nobody Mon Mar 23 23:30:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1773395603; cv=none; d=zohomail.com; s=zohoarc; b=e6AQyaEqS69ZAL1dAaNH3566Yr6JvpLnzLEiNtLQBLmqH2Gcu7/rhGi4NDWxSX1lGklJjfwo/gkFGTztjLz6wOmHhRfjKajji0FKHA6p63birZAF6APOW4n5wMyOSOVN3NDj6UhbvoWx73VfdI8KS2YM5QX4WnJnsEUnwJPztA8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773395603; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=9+3U4ijl8v6AOBR46Gb4h3o9ADCevWnk8hkYI1DfNG8=; b=eAphTx+dl+ekodGgoFNyU+OSb6J7A4JTPChzQRjGN+4oTzpZYIOWRlhsBjnFB7CbuoDhFFYefdGf1A6hoV5379Wx3rDn9Z7H5AljxRq/ZKbxxkYU5S81+dHEjSLJfr8ojRm1QcB+drMu/oONAbVJF8jv25sGA0pHxI16b2UKII8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1773395603575599.592793440275; Fri, 13 Mar 2026 02:53:23 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 9E8513F967; Fri, 13 Mar 2026 05:53:22 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id E14E84190D; Fri, 13 Mar 2026 05:52:49 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5AFE53F345; Fri, 13 Mar 2026 05:52:46 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 664363F933 for ; Fri, 13 Mar 2026 05:52:45 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-141-NRUtA0dMM_6s2BrQPIhjNw-1; Fri, 13 Mar 2026 05:52:43 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B9B71195FD11 for ; Fri, 13 Mar 2026 09:52:42 +0000 (UTC) Received: from antique-work.lan.rosnicka.net (unknown [10.44.33.141]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 10C741800351 for ; Fri, 13 Mar 2026 09:52:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773395565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9+3U4ijl8v6AOBR46Gb4h3o9ADCevWnk8hkYI1DfNG8=; b=NdR4OGo6IHYbaMUYczW8nGn3mpyfWMDMrAKwAVxO0fXVsNuxRUeoh1VPggvncVeCwuImPV R0L2WZqfMTsdq3o9DfFJXSN7+kHs2Hn5tN249Nea8qszrvSmI3NghjwsikZYzcOG8LNByH 0RqbPCRedxmAcAaivdpVzhKe6QdWLzo= X-MC-Unique: NRUtA0dMM_6s2BrQPIhjNw-1 X-Mimecast-MFC-AGG-ID: NRUtA0dMM_6s2BrQPIhjNw_1773395562 To: devel@lists.libvirt.org Subject: [libvirt PATCH] viriommufd: Set IOMMU_OPTION_RLIMIT_MODE only when running privileged Date: Fri, 13 Mar 2026 10:52:40 +0100 Message-ID: <39cff9b2fefe850e25b927a7671b7737100407e1.1773395552.git.phrdina@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: k8a1mxxfUr0iu_gUdoB7NwggYc-Ak6X63CUW1SY_eE0_1773395562 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: JBG6VZ6KT4HOFGCCPEYZQCVJKLMDOU7A X-Message-ID-Hash: JBG6VZ6KT4HOFGCCPEYZQCVJKLMDOU7A X-MailFrom: phrdina@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Pavel Hrdina via Devel Reply-To: Pavel Hrdina X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1773395605344154100 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Pavel Hrdina If libvirt daemon is running unprivileged it will fail so we should not even try to set it. Signed-off-by: Pavel Hrdina Reviewed-by: Jiri Denemark --- src/qemu/qemu_process.c | 2 +- src/util/viriommufd.c | 6 +++--- src/util/viriommufd.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index ab7cf03c0e..ecd05b4bf6 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7732,7 +7732,7 @@ qemuProcessOpenIommuFd(virDomainObj *vm) =20 VIR_DEBUG("Opening IOMMU FD for domain %s", vm->def->name); =20 - if ((iommufd =3D virIOMMUFDOpenDevice()) < 0) + if ((iommufd =3D virIOMMUFDOpenDevice(priv->driver->privileged)) < 0) return -1; =20 if (qemuSecuritySetImageFDLabel(priv->driver->securityManager, vm->def= , iommufd) < 0) diff --git a/src/util/viriommufd.c b/src/util/viriommufd.c index b62d59241d..82920923a2 100644 --- a/src/util/viriommufd.c +++ b/src/util/viriommufd.c @@ -80,14 +80,14 @@ virIOMMUFDSetRLimitMode(int fd, bool processAccounting) } =20 int -virIOMMUFDOpenDevice(void) +virIOMMUFDOpenDevice(bool privileged) { int fd =3D -1; =20 if ((fd =3D open(VIR_IOMMU_DEV_PATH, O_RDWR | O_CLOEXEC)) < 0) virReportSystemError(errno, "%s", _("cannot open IOMMUFD device")); =20 - if (virIOMMUFDSetRLimitMode(fd, true) < 0) { + if (privileged && virIOMMUFDSetRLimitMode(fd, true) < 0) { VIR_FORCE_CLOSE(fd); return -1; } @@ -98,7 +98,7 @@ virIOMMUFDOpenDevice(void) #else =20 int -virIOMMUFDOpenDevice(void) +virIOMMUFDOpenDevice(bool privileged G_GNUC_UNUSED) { virReportError(VIR_ERR_NO_SUPPORT, "%s", _("IOMMUFD is not supported on this platform")); diff --git a/src/util/viriommufd.h b/src/util/viriommufd.h index 223f44eb5c..7bad5c7472 100644 --- a/src/util/viriommufd.h +++ b/src/util/viriommufd.h @@ -22,6 +22,6 @@ =20 #define VIR_IOMMU_DEV_PATH "/dev/iommu" =20 -int virIOMMUFDOpenDevice(void); +int virIOMMUFDOpenDevice(bool privileged); =20 bool virIOMMUFDSupported(void); --=20 2.53.0