From nobody Sun Feb 8 15:25:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1661272446; cv=none; d=zohomail.com; s=zohoarc; b=kvzzxJQjX9urjxMOpP1MtLVcktIUkylzR7kbeJ+qn0FY9tP4Cx+IlNvws68ZdqQIZOekUW6pXOAVjqYURgnP0dV38qWXbsutENWLRMlceqV/z0pZ6hs9okcibnO0Rv+e+oPIYo4X6xEZW7+EDr72MsS9lo9UCYxJYewHYrSu3EQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661272446; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ej0p97fT8KPBX1ZOBQ12MLDQNpYF2vfuK7KP/++lXgg=; b=f3YeiNklb4fT2mOI7M5+EgOcvXENCtZH6kqUmii+2cbCJETFj2yse5HzUEjSUISgcg0vnTjFB44WDp+zUMmhutnZxUWsFTcBnE3rxIa9GG1exhCyvG/TUQ957aVqCDTGt0Rb8smv978/xg6o4CMo5/HlLzX1imlGLBXqScj3VdQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1661272446631768.550703025147; Tue, 23 Aug 2022 09:34:06 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-96-AgqaOsZ2NH-Yp9JtuCf38Q-1; Tue, 23 Aug 2022 12:33:07 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6DCEA851790; Tue, 23 Aug 2022 16:32:51 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5341B2166B2A; Tue, 23 Aug 2022 16:32:51 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 318471946A5C; Tue, 23 Aug 2022 16:32:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3ABC81946A40 for ; Tue, 23 Aug 2022 16:32:49 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2EFF6492C3B; Tue, 23 Aug 2022 16:32:49 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.192.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id C371B40315A for ; Tue, 23 Aug 2022 16:32:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661272445; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Ej0p97fT8KPBX1ZOBQ12MLDQNpYF2vfuK7KP/++lXgg=; b=JE8xqxvsFeMXmv1wbto/r2JgJmX6ZvTFyyKPkR3S+4EDXB+fDQikQnTdTnX1dG3ejAE90i cQq/UvBMzlOzlbMnMBiPnNrAE9NPlv5iPuhU9cDvFm1IATH2fmgJui4IJUQ+izbnHBoSO+ QAyd7hxozQmjnp6xv4MIMguPTCTpkZc= X-MC-Unique: AgqaOsZ2NH-Yp9JtuCf38Q-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt RFC 24/24] qemu_snapshot: allow deletion of external snapshot with internal snapshot children Date: Tue, 23 Aug 2022 18:32:27 +0200 Message-Id: <39a047f8e5bbdd6d91b8cc1169e35d403ef62446.1661271812.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1661272447810100002 Content-Type: text/plain; charset="utf-8"; x-default="true" --- Just example how we could support this specific use-case where snapshot in question is external and all children are only internal. But I would rather drop this patch and in the following patch series drop support for both children flags completely as users or management applications can to that themselves. src/qemu/qemu_snapshot.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 29d147f834..092bec6cc2 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -2835,6 +2835,7 @@ static int qemuSnapshotDeleteChildren(virDomainObj *vm, virDomainMomentObj *snap, virQEMUDriver *driver, + GPtrArray *externalData, bool metadata_only, unsigned int flags) { @@ -2850,7 +2851,7 @@ qemuSnapshotDeleteChildren(virDomainObj *vm, return -1; =20 if (flags & VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN) { - return qemuSnapshotDeleteSingle(vm, snap, driver, NULL, metadata_o= nly); + return qemuSnapshotDeleteSingle(vm, snap, driver, externalData, me= tadata_only); } =20 return 0; @@ -2906,13 +2907,6 @@ qemuSnapshotDeleteValidate(virDomainMomentObj *snap, return -1; } =20 - if (virDomainSnapshotIsExternal(snap) && - (flags & VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("deletion of external disk snapshot with internal= children disk snapshots not supported")); - return -1; - } - return 0; } =20 @@ -2943,9 +2937,7 @@ qemuSnapshotDelete(virDomainObj *vm, if (qemuSnapshotDeleteValidate(snap, flags) < 0) goto endjob; =20 - if (virDomainSnapshotIsExternal(snap) && - !(flags & (VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN | - VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN_ONLY))) { + if (virDomainSnapshotIsExternal(snap)) { if (!virDomainObjIsActive(vm)) { if (qemuProcessStart(NULL, driver, vm, NULL, VIR_ASYNC_JOB= _NONE, NULL, -1, NULL, NULL, @@ -2965,7 +2957,8 @@ qemuSnapshotDelete(virDomainObj *vm, =20 if (flags & (VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN | VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN_ONLY)) { - ret =3D qemuSnapshotDeleteChildren(vm, snap, driver, metadata_only= , flags); + ret =3D qemuSnapshotDeleteChildren(vm, snap, driver, externalData, + metadata_only, flags); } else { ret =3D qemuSnapshotDeleteSingle(vm, snap, driver, externalData, m= etadata_only); } --=20 2.37.2