From nobody Wed Dec 4 09:04:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1730901655055438.1038092802345; Wed, 6 Nov 2024 06:00:55 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id DB46E9A7; Wed, 6 Nov 2024 09:00:53 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 9A3BB157C; Wed, 6 Nov 2024 09:00:10 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id A68A815E0; Wed, 6 Nov 2024 09:00:05 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8B6891596 for ; Wed, 6 Nov 2024 08:59:55 -0500 (EST) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-298-BPM96YFGOQS1uXIEYoF_zg-1; Wed, 06 Nov 2024 08:59:52 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 34B1D1955F28 for ; Wed, 6 Nov 2024 13:59:51 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.225.164]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5AAC219541A5 for ; Wed, 6 Nov 2024 13:59:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730901595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kdH3pZBAeroeqafN3vF3RwoqfMcMBUGBAKhNgoHnmtg=; b=NnTXMxvHfL+IplaVxYNB1L3l4roilUAJ98J7TA+O3Y3clxZ60PMHTNp0ks4iJdFUaSRrsr q1HtrV0k+lkc337iHXNpptRF4m/2uPzxyD/abXfPRGFHyCJlnBrXj3u3si6s3Rho5RdoTs nvdwgOkxj0EemP7g2kxWYubtihLZZIs= X-MC-Unique: BPM96YFGOQS1uXIEYoF_zg-1 X-Mimecast-MFC-AGG-ID: BPM96YFGOQS1uXIEYoF_zg From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 2/3] util: json: check return value of virJSONValueFromJsonC Date: Wed, 6 Nov 2024 14:59:26 +0100 Message-ID: <39792eb94db9c9da028420a411d67c0f03e61c85.1730901567.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kHQNbtpUbw20f_VubtfMrOXd0Vn71tjclCpyE0vJl-c_1730901591 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: EO2XYQNGYREKW7SX3ZYTCPP67PH435YH X-Message-ID-Hash: EO2XYQNGYREKW7SX3ZYTCPP67PH435YH X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1730901656222116600 Content-Type: text/plain; charset="utf-8" In virJSONValueFromJsonC, the return value of virJSONValueFromJsonC was not checked in one case. Signed-off-by: J=C3=A1n Tomko --- src/util/virjson.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/util/virjson.c b/src/util/virjson.c index 18a4585e7b..a799707c16 100644 --- a/src/util/virjson.c +++ b/src/util/virjson.c @@ -1437,6 +1437,11 @@ virJSONValueFromJsonC(json_object *jobj) =20 cur =3D virJSONValueFromJsonC(val); =20 + if (!cur) { + g_free(ret); + return NULL; + } + virJSONValueArrayAppend(ret, &cur); } break; --=20 2.47.0