From nobody Thu Oct 31 22:54:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1653916143; cv=none; d=zohomail.com; s=zohoarc; b=GyowIPKS+9jgU2jLvyECEj7ezlmWj1/E8jhm7B33QC0DgtkRvw7HCwYgQnL3lACnGHG+csgpXpsN/ax6HtNF6zuGmNoWTZdR1uW/ZJW/OIfxrrYvTFu6hg7xCBYGfZs+v2QdFe+WFHBXW45sDC/XTtSEz8mKaQFINCxEccE1ZlU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653916143; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=2qDMldoLi+ZBr+pwnGXPIpR6rtqbIeOJGUgGqS2c/iE=; b=HNCW69wZiQcrSuREid1X9qYJ+8vhT9e4Ots+yZzRhob2XEifhKrIH2SgkbiM7a1zB7jn17X2AMrCp3F9p7UMjBrB0CopV8zT9TxPaRB35YO1rPRdt/MjgBDv7gXCQuVUgPVa2VKhWcu4+vXb+G9WQhYhyvZffXXdeI75r9WjKqE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1653916143623901.0644531387172; Mon, 30 May 2022 06:09:03 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-531--pktGA0lOry-s22BQKDaxA-1; Mon, 30 May 2022 09:08:03 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 637F3833976; Mon, 30 May 2022 13:07:50 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6029840F06B; Mon, 30 May 2022 13:07:46 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 386CC1947040; Mon, 30 May 2022 13:07:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3B5BA19466DF for ; Mon, 30 May 2022 13:07:45 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 11DEA407EE65; Mon, 30 May 2022 13:07:45 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.180]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC75A407EE63 for ; Mon, 30 May 2022 13:07:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653916142; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=2qDMldoLi+ZBr+pwnGXPIpR6rtqbIeOJGUgGqS2c/iE=; b=NrzgZr6vuZmeD8rJLDUygDTD7nYSRj4QSBhC02Vp4gaIHpOLGtggk0Z7ZJSfwbsNWlOcUC HnhihddKmHhf68ROw3QaJ3klY8UEYZ17tko1GrOX7ijU0axzR6bXG1s87i/fLg/7hKCBWL j+EV0iFfJh8gEkeMe27gvRKyP7A76TQ= X-MC-Unique: -pktGA0lOry-s22BQKDaxA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] qemu_capspriv: Drop needless declarations Date: Mon, 30 May 2022 15:07:42 +0200 Message-Id: <38f29ba5bfe3f78e22cc1830664c1af98096f1c6.1653916062.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1653916144928100001 Content-Type: text/plain; charset="utf-8"; x-default="true" There are two functions declared in qemu_capspriv.h: 1) virQEMUCapsInitHostCPUModel() which is not used anywhere but qemu_capabilities.c, 2) virQEMUCapsSetSEVCapabilities() which is my personal favorite but despite that it's never implemented nor called. Drop them. Signed-off-by: Michal Privoznik Reviewed-by: Boris Fiuczynski --- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capspriv.h | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index ce3e7d275a..d0c8217825 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3725,7 +3725,7 @@ virQEMUCapsNewHostCPUModel(void) } =20 =20 -void +static void virQEMUCapsInitHostCPUModel(virQEMUCaps *qemuCaps, virArch hostArch, virDomainVirtType type) diff --git a/src/qemu/qemu_capspriv.h b/src/qemu/qemu_capspriv.h index 26bf2d3571..fe24d01342 100644 --- a/src/qemu/qemu_capspriv.h +++ b/src/qemu/qemu_capspriv.h @@ -56,11 +56,6 @@ void virQEMUCapsSetArch(virQEMUCaps *qemuCaps, virArch arch); =20 -void -virQEMUCapsInitHostCPUModel(virQEMUCaps *qemuCaps, - virArch hostArch, - virDomainVirtType type); - void virQEMUCapsUpdateHostCPUModel(virQEMUCaps *qemuCaps, virArch hostArch, @@ -97,10 +92,6 @@ virQEMUCapsSetGICCapabilities(virQEMUCaps *qemuCaps, virGICCapability *capabilities, size_t ncapabilities); =20 -void -virQEMUCapsSetSEVCapabilities(virQEMUCaps *qemuCaps, - virSEVCapability *capabilities); - int virQEMUCapsProbeCPUDefinitionsTest(virQEMUCaps *qemuCaps, qemuMonitor *mon); --=20 2.35.1