From nobody Mon Sep 16 20:10:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694440371; cv=none; d=zohomail.com; s=zohoarc; b=cGWJBLsZ7j8w0fchuFhJmTEkxDgSp6Uj4skAnr33PsnANUpH7VjQSARgDVOJ5mWxFpuwTxvDXLE9ci8/4aZlCq5fzgol+YJ25PqgvGU/M+5HiDSzo76QuaIvm/3hkn5N/ZnEsd0yGiyK+Z0LV1xcpqjgoE5rf6bm/NELWyUo9AE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694440371; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3sBc5Q4BdOUIhn2uPKDmubHxlxQjf1JAEvEVSUMwqmM=; b=E+mXXL7D8mH16BOj7IQblovS+eNQrYE03UHaUVha1cJolC8YAJBZ/JLffFlXlc3xxuXwcywG2ZuNd7h9h5M0YGRpbrph+bl96xAaSSp8HrSFkEVgITI6SJ+TOv7TBOm4Srhjlzh7FyW7ZkWoWKgz+0VXe8XChBzFOQW0LcN06KU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1694440371829283.1827128678465; Mon, 11 Sep 2023 06:52:51 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-512-_FweAKryMtWIZDP1LVxy6Q-1; Mon, 11 Sep 2023 09:52:41 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 652C529DD99E; Mon, 11 Sep 2023 13:52:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C3A440C6EC0; Mon, 11 Sep 2023 13:52:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 90BCE19465B3; Mon, 11 Sep 2023 13:52:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BF09B19465A4 for ; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 980B21006B5C; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) Received: from fedora.. (unknown [10.43.2.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3B96610F1BE9 for ; Mon, 11 Sep 2023 13:52:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694440370; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=3sBc5Q4BdOUIhn2uPKDmubHxlxQjf1JAEvEVSUMwqmM=; b=ZCs8u3VCeaYDzKVUqE3Yf3QtCOG3zCpcnbqo/bUJhZkFxpHPCOGK6ZY57saocacpRsOWxz CdgjBZwnzFLr/JetoY8Vr0NxbWRz1mRsCaWLoV63Ou92mND1zlQrbrkMfboKqkE3B49tkJ 144LvscKZjkGM8fxVl12gncRpFWWXbY= X-MC-Unique: _FweAKryMtWIZDP1LVxy6Q-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCHv1 7/8] qemu: allow running virtiofsd in session mode Date: Mon, 11 Sep 2023 15:51:27 +0200 Message-ID: <38e48dc7244221084ab3232f46db1e860bd7d81d.1694440288.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694440404983100003 https://gitlab.com/libvirt/libvirt/-/issues/535 Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_validate.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index e3c34eca3d..da7b0ff419 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -4229,7 +4229,7 @@ qemuValidateDomainDeviceDefGraphics(const virDomainGr= aphicsDef *graphics, static int qemuValidateDomainDeviceDefFS(virDomainFSDef *fs, const virDomainDef *def, - virQEMUDriver *driver, + virQEMUDriver *driver G_GNUC_UNUSED, virQEMUCaps *qemuCaps) { if (fs->type !=3D VIR_DOMAIN_FS_TYPE_MOUNT) { @@ -4286,11 +4286,6 @@ qemuValidateDomainDeviceDefFS(virDomainFSDef *fs, _("virtiofs does not yet support read-only = mode")); return -1; } - if (!driver->privileged) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("virtiofs is not yet supported in session= mode")); - return -1; - } if (fs->accessmode !=3D VIR_DOMAIN_FS_ACCESSMODE_PASSTHROUGH) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("virtiofs only supports passthrough acces= smode")); --=20 2.41.0