From nobody Mon Feb 9 03:14:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1636986253; cv=none; d=zohomail.com; s=zohoarc; b=fZH9GCmCRflGyvfH7+aKrH9EaihNy5Ty1Kt4HxYpD4Y64Zj3t59G1CLXhndBmHdEESyDlx1w/jpN93WeqYNhGbjWGaYaCW+EkWmUijJt3PJ/2OLBkv/QG1Pt+FOjxBJRGDwvOznYIhpOIC+2O+OKQSCNBz9vE44LM8CjuEgCCos= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636986253; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CGdSsnP45VzQrQ53lGOk+PmCzwikxcVDG+ah8WhSKv4=; b=LjvNHdMzmsMYsrsSgujRqHMjDgH52hY2TeQDgH+mlnrdlIhk2KY83gKYR5RLaeLXXiR8tOCYgIN23SjPBa3kbCTTOBdBujmxXESCKS7b8yEkNexvwzHb+M6RvfUp7j6fm8p/qtL2BGT861vEWpMoH4HlqJx/FjhRi8U0+viIrhs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1636986253330943.654504708774; Mon, 15 Nov 2021 06:24:13 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500-Nd6ilrtjPFmA9IN_nPMQXA-1; Mon, 15 Nov 2021 09:22:56 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CE67B19200D0; Mon, 15 Nov 2021 14:22:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ACBFB1972D; Mon, 15 Nov 2021 14:22:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 82964181A1D1; Mon, 15 Nov 2021 14:22:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AFEMT1o009746 for ; Mon, 15 Nov 2021 09:22:29 -0500 Received: by smtp.corp.redhat.com (Postfix) id 396115BB06; Mon, 15 Nov 2021 14:22:29 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D40E78B20 for ; Mon, 15 Nov 2021 14:22:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636986252; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=CGdSsnP45VzQrQ53lGOk+PmCzwikxcVDG+ah8WhSKv4=; b=KmVLw4O/wYQrgSieRAhN4hdZRnq9sORJNJxWP3Af73FCZjx0q5gtYzhwVrVtaAQlbJ7ZVK QsmMr7tXZwFklNgsFTA8PH+jpmZ7YnRw7LeXA4/mhaAxSPlYMyTICX1FhpCwfUVACgMI47 PQEpXNQ8OBYf0+t677srsstFL1+kAPw= X-MC-Unique: Nd6ilrtjPFmA9IN_nPMQXA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 09/18] qemuDiskSourceGetProps: Initialize 'ret' Date: Mon, 15 Nov 2021 15:22:08 +0100 Message-Id: <389ee67a12f90714b0284f2ade817c31eefc172e.1636986086.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1636986325155100001 Content-Type: text/plain; charset="utf-8" Upcomming patch will convert virJSONValueObjectCreate which didn't check the value of the passed argument to virJSONValueObjectAdd which will and this would lead to crashes. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 17ff7a5fe2..e63e82e261 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1616,7 +1616,7 @@ static virJSONValue * qemuDiskSourceGetProps(virStorageSource *src) { g_autoptr(virJSONValue) props =3D NULL; - virJSONValue *ret; + virJSONValue *ret =3D NULL; if (!(props =3D qemuBlockStorageSourceGetBackendProps(src, QEMU_BLOCK_STORAGE= _SOURCE_BACKEND_PROPS_LEGACY))) --=20 2.31.1